Details

lib/libusb/libusb10_desc.c
730	are there any scenarios where there'll be uninit'ed data from malloc() that you aren't overwriting with the relevant capability info? (Normally I use calloc()) for stuff like this so it's zero-init'ed and I don't need to worry about leaking info.

Use calloc

lib/libusb/libusb10_desc.c
730	No. The size malloced will be fill by memcpy later. However, it is harmless to use calloc so we can switch to it.

lwhsu added inline comments.

lib/libusb/libusb10_desc.c
723	Will this be an issue that we dereference `bos_cap` before checking if it's NULL in `if (bos_cap == NULL` ?

lib/libusb/libusb10_desc.c
735	Do we need to free() `desc` since it's allocated by calloc() above? Or maybe move this part before calling calloc() ?

emaste added inline comments.

lib/libusb/libusb10_desc.c
723	Indeed, this is the sort of issue Coverity will complain about as well. Either `bos_cap` can be NULL and we need to check here before dereferencing, or it cannot be NULL and the check below is unnecessary. It looks like lgpl libusb just assumes it is not NULL.

Fix potential errors

Other than the moving length checking part, I think this is fine.

lib/libusb/libusb10_desc.c
735	I still prefer to move this check closer to the beginning of this function, right after `if (bos_cap == NULL \|\|` check, as it can avoid unnecessary calling to calloc()/free().

This revision is now accepted and ready to land.Aug 5 2025, 6:06 PM

lib/libusb/libusb10_desc.c
735	Agreed, in general I'd put those kinds of tests before resource allocation etc.

This revision was automatically updated to reflect the committed changes.

libusb: implement libusb_get_platform_descriptor
ClosedPublic
Actions