Page MenuHomeFreeBSD
Differential D50306

snd_hda: Add shutdown method
ClosedPublic
Actions

Authored by tijl on May 12 2025, 10:41 AM.
Tags
None
Referenced Files
F158005708: D50306.diff
Wed, May 27, 10:09 AM
Unknown Object (File)
Fri, May 15, 7:35 AM
Unknown Object (File)
Fri, May 15, 5:27 AM
Unknown Object (File)
Thu, May 14, 10:02 PM
Unknown Object (File)
Thu, May 14, 7:23 PM
Unknown Object (File)
Wed, May 13, 3:04 PM
Unknown Object (File)
Thu, May 7, 9:56 AM
Unknown Object (File)
Apr 22 2026, 3:47 PM
View All 92 Files
Subscribers
cperciva
imp

Details

Reviewers
christos
adrian
Commits
rGadf77cb48e4c: snd_hda: Add shutdown method
rG77521692f4c7: snd_hda: Add shutdown method
rGd9900b9ea2b2: snd_hda: Add shutdown method
Summary

Power down the device on shutdown similar to what is done in the case
of suspend. The device may fail to attach on next boot without this.

PR: 286385

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64099
Build 60983: arc lint + arc unit

Event Timeline

tijl created this revision.May 12 2025, 10:41 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 12 2025, 10:41 AM
tijl requested review of this revision.May 12 2025, 10:41 AM
Harbormaster completed remote builds in B64099: Diff 155314.May 12 2025, 10:41 AM
christos added a comment.May 12 2025, 1:47 PM

In the PR we discussed putting the callout and taskqueue stuff before the bus_generic_detach() call in hdac_detach(). Should the same apply here to make it more robust?

tijl updated this revision to Diff 155610.May 17 2025, 11:47 AM

Drain callout and taskqueue before shutting down child devices

Harbormaster completed remote builds in B64241: Diff 155610.May 17 2025, 11:47 AM
christos added a reviewer: adrian.May 17 2025, 6:40 PM
christos added a subscriber: cperciva.May 17 2025, 7:29 PM

LGTM. We'll also need to MFC this to both stable/14 and releng/14.3.
CC @cperciva

christos accepted this revision.May 17 2025, 7:30 PM
This revision is now accepted and ready to land.May 17 2025, 7:30 PM
adrian accepted this revision.May 17 2025, 9:20 PM

nice catch!

Closed by commit rGd9900b9ea2b2: snd_hda: Add shutdown method (authored by tijl). · Explain WhyMay 18 2025, 1:40 PM
This revision was automatically updated to reflect the committed changes.
tijl added a commit: rGd9900b9ea2b2: snd_hda: Add shutdown method.
christos added a commit: rG77521692f4c7: snd_hda: Add shutdown method.May 21 2025, 7:45 PM
christos added a commit: rGadf77cb48e4c: snd_hda: Add shutdown method.May 21 2025, 11:23 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
hda/
31 lines

Diff 155314

View Options

sys/dev/sound/pci/hda/hdac.c

Loading...