Differential D50044

e6000sw: add support for 88E6190X
ClosedPublic
Actions

Authored by adrian on Apr 26 2025, 3:49 PM.

Details

Reviewers

imp

Commits

rG9b2a503a1179: e6000sw: add support for 88E6190X

Summary

This adds the minimum support required to probe/attach the 88E6190X.

I've tested this against an AT&T ATT-150 OCP device (Silicom i3000)
with local changes to export MDIO via ixge(4).

Hints are required to probe/attach/configure the switch on amd64,
but with the mentioned diffs, it does work.

Thanks to Stas Alekseev <stas@alekseev.us> for the pull request
and Stas / Jason Hensler <omegadraconis@gmail.com> for chasing
down information about the chipset, linux stuff and AT&T OCP
hardware information.

PR: kern/281211
Pull Request: https://github.com/freebsd/freebsd-src/pull/1408

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63746
Build 60630: arc lint + arc unit

Event Timeline

adrian created this revision.Apr 26 2025, 3:49 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 26 2025, 3:49 PM

adrian requested review of this revision.Apr 26 2025, 3:49 PM

Harbormaster completed remote builds in B63746: Diff 154319.Apr 26 2025, 3:49 PM

adrian added a parent revision: D50031: e6000sw: schedule e6000sw_tick() to occur once a second.Apr 26 2025, 3:54 PM

adrian added a reviewer: imp.

adrian added a child revision: D50045: mii: Change e1000phy (Marvell 88E1000) PHYs to disable power down / isolate.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2025, 6:39 PM

Closed by commit rG9b2a503a1179: e6000sw: add support for 88E6190X (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG9b2a503a1179: e6000sw: add support for 88E6190X.

jrtc27 added a subscriber: jrtc27.May 4 2025, 5:51 PM

jrtc27 added inline comments.

sys/dev/etherswitch/e6000sw/e6000sw.c
267–271
sys/dev/etherswitch/e6000sw/e6000swreg.h
60	These lines are too long, though they were a bit over the character limit already so eh...

adrian added inline comments.May 4 2025, 5:56 PM

sys/dev/etherswitch/e6000sw/e6000swreg.h
60	I have some ideas on cleaning this stuff up later, once the ixgbe MDIO stuff is in -head and others can just boot -head and jump in. One (in this particular instance) is to store the offsets as a per-chipset config during probe/attach and do away with the ternary operator here. It'll be a bit delicate as the quirk is required /during/ probe/attach to check the correct registers, but I think it'll make everything correct-er.