e6000sw: unlock the driver lock in the error path during attach
ClosedPublic
Actions

Authored by adrian on Fri, Apr 25, 6:39 PM.

Details

Reviewers

Commits

rGaf298663e9ff: e6000sw: unlock the driver lock in the error path during attach

Summary

The driver sleep lock was being held during most of the error paths,
and not unlocking it will panic the kernel during detach. So, fix it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63734
Build 60618: arc lint + arc unit

Event Timeline

adrian created this revision.Fri, Apr 25, 6:39 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 25, 6:39 PM

adrian requested review of this revision.Fri, Apr 25, 6:39 PM

Harbormaster completed remote builds in B63734: Diff 154298.Fri, Apr 25, 6:39 PM

adrian added a parent revision: D50028: e6000sw: always compile it.Fri, Apr 25, 6:47 PM

adrian added a child revision: D50030: e6000sw: stop / drain the taskqueue (and tick) during detach.

imp accepted this revision.Fri, Apr 25, 7:37 PM

This revision is now accepted and ready to land.Fri, Apr 25, 7:37 PM

Closed by commit rGaf298663e9ff: e6000sw: unlock the driver lock in the error path during attach (authored by adrian). · Explain WhySun, Apr 27, 6:39 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGaf298663e9ff: e6000sw: unlock the driver lock in the error path during attach.

Revision Contents
Changeset List

Path

Size

sys/

dev/

etherswitch/

e6000sw/

e6000sw.c

1 line

Diff 154298

View Options

sys/dev/etherswitch/e6000sw/e6000sw.c

e6000sw: unlock the driver lock in the error path during attachClosedPublicActions