Page MenuHomeFreeBSD
Differential D49767

wlanstats: add crypto_swcipherfail
ClosedPublic
Actions

Authored by adrian on Apr 10 2025, 8:42 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Sep 12, 9:51 PM
Unknown Object (File)
Thu, Sep 4, 9:38 AM
Unknown Object (File)
Thu, Sep 4, 4:55 AM
Unknown Object (File)
Thu, Sep 4, 1:41 AM
Unknown Object (File)
Aug 15 2025, 3:16 PM
Unknown Object (File)
Aug 15 2025, 6:57 AM
Unknown Object (File)
Aug 15 2025, 12:19 AM
Unknown Object (File)
Aug 4 2025, 9:11 PM
View All 36 Files
Subscribers
bz
imp

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG0e99e55d1866: wlanstats: add crypto_swcipherfail
Summary

This adds the is_crypto_swcipherfail counter to wlanstats.
This counter counts the instances of failing to find support
for a requested cipher being handled completely in software.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63437
Build 60321: arc lint + arc unit

Event Timeline

adrian created this revision.Apr 10 2025, 8:42 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 10 2025, 8:42 PM
adrian requested review of this revision.Apr 10 2025, 8:42 PM
Harbormaster completed remote builds in B63437: Diff 153478.Apr 10 2025, 8:43 PM
adrian added a parent revision: D49766: net80211: fix ff_approx_txtime() to handle VHT rates.Apr 10 2025, 8:43 PM
adrian added a reviewer: wireless.
adrian added a project: wireless.
bz requested changes to this revision.Apr 12 2025, 7:39 PM
bz added a subscriber: bz.

The ones from 2d4583c462a5d7904e2bb4c77f521d16fd2e7140 are still missing.

This revision now requires changes to proceed.Apr 12 2025, 7:39 PM
adrian added a comment.Apr 12 2025, 8:25 PM

Aren't they in 02a8d40c9ffb2987c291ea96cf7be7c012b359a3 ?

bz added a comment.Apr 12 2025, 8:43 PM

% git show 02a8d40c9ffb2987c291ea96cf7be7c012b359a3
fatal: bad object 02a8d40c9ffb2987c291ea96cf7be7c012b359a3

adrian added a comment.Apr 12 2025, 8:43 PM
In D49767#1135362, @bz wrote:

% git show 02a8d40c9ffb2987c291ea96cf7be7c012b359a3
fatal: bad object 02a8d40c9ffb2987c291ea96cf7be7c012b359a3

Hmph, lemme see what happened.

adrian added a comment.Apr 12 2025, 8:45 PM
In D49767#1135362, @bz wrote:

% git show 02a8d40c9ffb2987c291ea96cf7be7c012b359a3
fatal: bad object 02a8d40c9ffb2987c291ea96cf7be7c012b359a3

ok, try https://reviews.freebsd.org/D49162

It looks like it's landed fine in -head. Even the diff above shows the counters for the GCMP stuff.

bz accepted this revision.Apr 12 2025, 8:53 PM

May bad. I checked with the is_ prefix if my history is right.

This revision is now accepted and ready to land.Apr 12 2025, 8:53 PM
adrian added a child revision: D49929: asmc: Add support for macmini 6,1 and 6,2 (late 2012) models.Apr 20 2025, 3:10 PM
Closed by commit rG0e99e55d1866: wlanstats: add crypto_swcipherfail (authored by adrian). · Explain WhyApr 23 2025, 2:04 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG0e99e55d1866: wlanstats: add crypto_swcipherfail.

Revision Contents
Changeset List

PathSize
usr.sbin/
wlanstats/
4 lines

Diff 153478

View Options

usr.sbin/wlanstats/wlanstats.c

Loading...