netinet: rename in_broadcast() to in_ifnet_broadcast()
ClosedPublic
Actions

Authored by glebius on Feb 17 2025, 11:37 PM.

Details

Reviewers

rstone
markj

Group Reviewers

network
transport

Commits

rG197fc4cad097: netinet: rename in_broadcast() to in_ifnet_broadcast()

Summary

This aligns with existing in_ifaddr_broadcast() and aligns with other
simple functions or macros with bare "in_" prefix that operator just on
struct in_addr and nothing else, e.g. in_nullhost(). No functional
change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62493
Build 59377: arc lint + arc unit

Event Timeline

glebius created this revision.Feb 17 2025, 11:37 PM

Herald added a reviewer: transport. · View Herald TranscriptFeb 17 2025, 11:37 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Feb 17 2025, 11:37 PM

glebius added a parent revision: D49040: tests/netinet: add few tests for sending a broadcast packet.

glebius added a child revision: D49042: netinet: enforce broadcast mode for all-ones and all-zeroes destinations.

Harbormaster completed remote builds in B62493: Diff 151133.Feb 17 2025, 11:38 PM

This is preparation for D49042. Please review them together.

markj accepted this revision as: markj.Feb 18 2025, 9:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2025, 2:13 AM

Closed by commit rG197fc4cad097: netinet: rename in_broadcast() to in_ifnet_broadcast() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG197fc4cad097: netinet: rename in_broadcast() to in_ifnet_broadcast().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

2 lines

2 lines

2 lines

2 lines

2 lines

6 lines

2 lines

Diff 151133

View Options

sys/netinet/in.h

View Options

sys/netinet/in.c

View Options

sys/netinet/in_rmx.c

View Options

sys/netinet/ip_divert.c

View Options

sys/netinet/sctp_os_bsd.h

View Options

sys/netinet/tcp_input.c

View Options

netinet: rename in_broadcast() to in_ifnet_broadcast()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 151133

sys/netinet/in.h

sys/netinet/in.c

sys/netinet/in_rmx.c

sys/netinet/ip_divert.c

sys/netinet/sctp_os_bsd.h

sys/netinet/tcp_input.c

sys/netinet/udp_usrreq.c

netinet: rename in_broadcast() to in_ifnet_broadcast()
ClosedPublic
Actions

Revision Contents
Changeset List