Differential D48605

net80211: add ieee80211_node_get_txrate() to populate the "new" transmit struct
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:36 AM.

Tags

Referenced Files

	F133342321: D48605.id151030.diff
	Sat, Oct 25, 1:40 AM

	F133275189: D48605.id150001.diff
	Fri, Oct 24, 1:14 PM

	F133226852: D48605.diff
	Fri, Oct 24, 3:33 AM

	F133224545: D48605.id151030.diff
	Fri, Oct 24, 3:05 AM

	Unknown Object (File)
	Thu, Oct 23, 9:45 PM

	Unknown Object (File)
	Wed, Oct 15, 4:02 AM

	Unknown Object (File)
	Tue, Oct 14, 9:57 AM

	Unknown Object (File)
	Tue, Oct 14, 7:24 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG0da0a5fc73e6: net80211: add ieee80211_node_get_txrate() to populate the "new" transmit struct

Summary

ieee80211_node_get_txrate() populates the passed-in ieee80211_node_txrate with
the current rate configuration.

This is a no-op - nothing is yet setting VHT rates.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62439
Build 59323: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:36 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:36 AM

adrian requested review of this revision.Jan 23 2025, 2:36 AM

Harbormaster completed remote builds in B61896: Diff 149734.Jan 23 2025, 2:36 AM

adrian added a parent revision: D48604: net80211: convert ni_txrate to a struct, with extra rate information.Jan 23 2025, 2:36 AM

adrian added a child revision: D48606: rtwn: move to using ieee80211_node_get_txrate().

adrian added a reviewer: wireless.Jan 23 2025, 3:03 AM

adrian added a project: wireless.

simplify / type-safe

Harbormaster completed remote builds in B61910: Diff 149748.Jan 23 2025, 3:10 AM

rebase

Harbormaster completed remote builds in B61956: Diff 149845.Jan 24 2025, 1:51 AM

rebase

Harbormaster completed remote builds in B61983: Diff 149897.Jan 24 2025, 3:31 PM

rebase, address changes

Harbormaster completed remote builds in B62049: Diff 150001.Jan 27 2025, 12:16 AM

bz added a subscriber: bz.Jan 29 2025, 12:55 AM

bz added inline comments.

sys/net80211/ieee80211_node.c
3188	I love KASSERTs or MPASS to check passed in pointers to not be NULL. Just happens once too often net80211 still and ni is prone to it ... Also no new line needed if there is no declaration.
sys/net80211/ieee80211_node.h
523	This indent looks wrong at least in Phabricator.

update, add TXRATE_HT

Harbormaster completed remote builds in B62112: Diff 150147.Jan 30 2025, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62127: Diff 150162.Jan 30 2025, 5:15 AM

adrian added inline comments.Feb 14 2025, 3:25 PM

sys/net80211/ieee80211_node.h
523	yup, I didn't do two tabs, I'll fix it in a sec.

feedback from bz

Harbormaster completed remote builds in B62439: Diff 151030.Feb 14 2025, 3:33 PM

adrian marked an inline comment as done.Feb 14 2025, 3:33 PM

bz added inline comments.Feb 15 2025, 12:26 PM

sys/net80211/ieee80211_node.h
523	Have you?

bz accepted this revision.Feb 15 2025, 12:44 PM

bz added inline comments.

sys/net80211/ieee80211_node.h
523	Apparently yes, looks good now.

This revision is now accepted and ready to land.Feb 15 2025, 12:44 PM

adrian marked 3 inline comments as done.Feb 16 2025, 8:49 PM

Closed by commit rG0da0a5fc73e6: net80211: add ieee80211_node_get_txrate() to populate the "new" transmit struct (authored by adrian). · Explain WhyFeb 26 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG0da0a5fc73e6: net80211: add ieee80211_node_get_txrate() to populate the "new" transmit struct.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_node.h

2 lines

ieee80211_node.c

20 lines

Diff 151030

sys/net80211/ieee80211_node.h

Loading...

sys/net80211/ieee80211_node.c

Loading...