preliminary usb support for fwget
Needs RevisionPublic
Actions

Authored by jsm on Jan 25 2025, 9:50 AM.

Details

Reviewers

imp
manu
bz
jbeich

Group Reviewers

wireless
USB
manpages

Summary

Mostly a copy of pci subsystem support, by replacing pciconf with usbconfig and excluding hardware classes.

Test Plan

fwget usb (with a matched device attached)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jsm requested review of this revision.Jan 25 2025, 9:50 AM

jsm created this revision.

sed correct use of quantifier and use * instead of +

bz added a reviewer: USB.Jan 25 2025, 10:26 AM

I was pondering this for a while -- also for other devices -- but I highly felt that usbconfig wanted some improvements first to make this a lot easier.
There are tricky bits with USB devices changing "identity" depending on quirks or other state (i.e., first show up as CD-ROM and then become a network device).

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

usr.sbin/fwget/usb/usb
60	looks like an indent problem here in Phabricator?
usr.sbin/fwget/usb/usb_ralink
6	I do not think there's anything from the Foundation or me in this file.

Perfectly fine

In D48678#1110205, @bz wrote:

I was pondering this for a while -- also for other devices -- but I highly felt that usbconfig wanted some improvements first to make this a lot easier.
There are tricky bits with USB devices changing "identity" depending on quirks or other state (i.e., first show up as CD-ROM and then become a network device).

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

Perfectly fine with me.

I'm not familar with fwget code and don't use WiFi, so can't review.

In D48678#1110205, @bz wrote:

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

Perfectly fine with me.

Not made it and likely will not the next 3-4 days. If this needs to go in, please let me know and I'll review the current version and then defer any further changes to the future.

Manu wrote fwget so, adding him.

I think for fwget.8 you can just `%s/default pci/valid types are:
.Dv pci ,
.Dv usb ./"

(But I don't actually know the syntax for using newlines in a replace)

I'm fine with this but maybe we should expand the manpage to list subsystems

Just some nits, see also https://reviews.freebsd.org/D48944

ziaee accepted this revision as: manpages.Tue, Feb 11, 5:30 PM

ziaee added a reviewer: manpages.

bz mentioned this in D48974: usbconfig: add -l option to dump_device_desc for single line output.Wed, Feb 12, 11:06 PM

changes after https://reviews.freebsd.org/D48974

I'll try to get D48974 in.
If you fix the man page, empty line and remove the "portions of this..." from usb_ralink I hope we'll be good to go.

usr.sbin/fwget/fwget.8
26	Please don't forget to update .Dd before comitting
usr.sbin/fwget/usb/usb
41	unneeded empty line

This revision now requires changes to proceed.Sat, Feb 22, 12:41 PM

bz mentioned this in rGc66308d7bcc3: usbconfig: add -l option to dump_device_desc for single line output.Mon, Feb 24, 1:00 AM

bz mentioned this in rG7907a9276081: usbconfig: add -l option to dump_device_desc for single line output.Wed, Feb 26, 11:46 PM

I see no change in fwget output when testing using git-arc.sh patch -C D48678; cd usr.sbin/fwget; make install; fwget on todays's CURRENT .

I have an Intel AX211, I do not know if it needs the firmware from comms/iwmbt-firmware, but when I install it manually my dmesg does change.

In D48678#1122262, @ziaee wrote:

I see no change in fwget output when testing using git-arc.sh patch -C D48678; cd usr.sbin/fwget; make install; fwget on todays's CURRENT .

I have an Intel AX211, I do not know if it needs the firmware from comms/iwmbt-firmware, but when I install it manually my dmesg does change.

This doesn't add any BT devices; I have a TODO to do so when this landed.