Page MenuHomeFreeBSD

preliminary usb support for fwget
Needs ReviewPublic

Authored by jsm on Sat, Jan 25, 9:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 4, 7:03 AM
Unknown Object (File)
Fri, Jan 31, 6:03 AM
Unknown Object (File)
Fri, Jan 31, 3:42 AM
Unknown Object (File)
Tue, Jan 28, 3:10 AM
Subscribers

Details

Reviewers
imp
jbeich
Group Reviewers
wireless
USB
Summary

Mostly a copy of pci subsystem support, by replacing pciconf with usbconfig and excluding hardware classes.

Test Plan

fwget usb (with a matched device attached)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jsm requested review of this revision.Sat, Jan 25, 9:50 AM
jsm created this revision.

sed correct use of quantifier and use * instead of +

I was pondering this for a while -- also for other devices -- but I highly felt that usbconfig wanted some improvements first to make this a lot easier.
There are tricky bits with USB devices changing "identity" depending on quirks or other state (i.e., first show up as CD-ROM and then become a network device).

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

usr.sbin/fwget/usb/usb
60

looks like an indent problem here in Phabricator?

usr.sbin/fwget/usb/usb_ralink
6

I do not think there's anything from the Foundation or me in this file.

Perfectly fine

In D48678#1110205, @bz wrote:

I was pondering this for a while -- also for other devices -- but I highly felt that usbconfig wanted some improvements first to make this a lot easier.
There are tricky bits with USB devices changing "identity" depending on quirks or other state (i.e., first show up as CD-ROM and then become a network device).

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

Perfectly fine with me.

I'm not familar with fwget code and don't use WiFi, so can't review.

In D48678#1110205, @bz wrote:

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

Perfectly fine with me.

Not made it and likely will not the next 3-4 days. If this needs to go in, please let me know and I'll review the current version and then defer any further changes to the future.