fix up the flavor part, so that the specific pkg includes the binary firmware

[jsm]

Summary

Also make PORTREVISION overridable

Test Plan

make FLAVOR=mt7601u package

[bz]

I usually just bump them all together but I see why we may not want to anymore now.

net/wifi-firmware-mtw-kmod/Makefile

0

I cannot imagine Linux calling the firmware mtw? This likely is wrong and should be mt7601u ?

0

That is the wrong license file for your driver. See WHENCE

11

This should be something like
``
LICENSE_NAME= Mediatek firmware license (${FWDRV})
``

[jsm]

net/wifi-firmware-mtw-kmod/Makefile

0

After looking into this in my understanding the FWDRV cannot be the same as FWSUBS? So in this case of a (for now) one flavor port, should we modify the Makefile.inc to omit the multiple flavors in case of the same name or should we keep the name as the name of the freebsd driver?

0

Yup, if I am not mistaken https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/LICENCE.ralink_a_mediatek_company_firmware?h=20241210 is the correct one so LICENSE_FILE=LICENCE.ralink_a_mediatek_company_firmware

[bz]

If you don't mind that the firmware is called by the official name ( wifi-firmware-mt7601u-kmod -- in that case I'd likely also rename the dir ) you could try this Makefile (needs a make makesum afterwards). I haven't run it through pourdier yet only done a manual make. We'll likely once the naming is sorted also want to add it to the default RUN_DEPENDS of net/wifi-firmware-kmod/Makefile

BASEDIR=        ${.CURDIR}/../wifi-firmware-kmod
PORTREVISION=   2

FWDRV=          mt7601u
FWSUBDIR=       mediatek
FWDRV_VERSION=  20241017

LICENSE_FILE=   LICENCE.ralink_a_mediatek_company_firmware
LICENSE_NAME=   Ralink, A MediaTek Company license (${FWDRV})

WHENCE_REGEX=   mt7601u

FWSUBS=         # No flavours

DISTFILES_${FWDRV}= \
        ${FWSUBDIR}/mt7601u.bin${DISTURL_SUFFIX}
DISTFILES_${FWDRV}_lic=

.include "${BASEDIR}/Makefile.inc"

[bz]

Fine from my side. I am not a ports committer though so whatever ports needs Ports Committers can help if needed.

net/wifi-firmware-mt7601u-kmod/Makefile

7

extra blank line you can remove before committing.