libvmmapi: Fix auto-loading of vmm.ko
ClosedPublic
Actions

Authored by markj on Feb 2 2025, 9:45 PM.

Details

Reviewers

jhb

Group Reviewers

bhyve

Commits

rG23a28fe7776f: libvmmapi: Fix auto-loading of vmm.ko

Summary

We should autoload vmm.ko when creating a VM with vm_openf(), to preserve behaviour prior to commit 99127fd10362.
kldload(2) returns a non-zero value upon success, so the existing code was wrong.

Reported by: olivier
Fixes: 99127fd10362 ("libvmmapi: Use the vmmctl device file to create and destroy VMs")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62208
Build 59092: arc lint + arc unit

Event Timeline

markj created this revision.Feb 2 2025, 9:45 PM

Herald added subscribers: rgrimes, imp. · View Herald TranscriptFeb 2 2025, 9:45 PM

markj requested review of this revision.Feb 2 2025, 9:45 PM

Harbormaster completed remote builds in B62208: Diff 150380.Feb 2 2025, 9:45 PM

I don't really like the auto-loading, but that's how it used to work, and changing it in 15.0 would be a POLA violation.

jhb added inline comments.Feb 4 2025, 3:25 PM

lib/libvmmapi/vmmapi.c
119	Why is this `vm_device_open(name)` instead of `vm_ctl_open()`?

Fix a silly mistake in the legacy vm_create().

Harbormaster completed remote builds in B62240: Diff 150470.Feb 4 2025, 3:31 PM

I'm somewhat ambivalent about the auto-loading. I might have preferred some sort of "vmm_init" function in the library that handled that, but that ship has sailed.

This revision is now accepted and ready to land.Feb 4 2025, 3:51 PM

Closed by commit rG23a28fe7776f: libvmmapi: Fix auto-loading of vmm.ko (authored by markj). · Explain WhyFeb 6 2025, 4:28 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG23a28fe7776f: libvmmapi: Fix auto-loading of vmm.ko.