Differential D48608

net80211: add valid VHT MCS combinations and helper functions
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:38 AM.

Tags

Referenced Files

	F135553882: D48608.id150165.diff
	Mon, Nov 10, 6:41 PM

	F135546030: D48608.id149900.diff
	Mon, Nov 10, 5:09 PM

	F135526642: D48608.id150004.diff
	Mon, Nov 10, 1:32 PM

	F135512044: D48608.id150150.diff
	Mon, Nov 10, 10:54 AM

	F135484373: D48608.id151524.diff
	Mon, Nov 10, 5:51 AM

	F135481861: D48608.id149848.diff
	Mon, Nov 10, 5:26 AM

	Unknown Object (File)
	Thu, Nov 6, 2:28 AM

	Unknown Object (File)
	Wed, Nov 5, 3:51 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG1568caaf5721: net80211: add valid VHT MCS combinations and helper functions

Summary

Not all NSS / MCS / channel bandwidth combinations are valid.

This will be important for rate control and transmit rate
setup (eg static management, unicast, multicast rates.)

This is based on 802.11-2020 Section 21.5 (Parameters for VHT-MCSs.)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62130
Build 59014: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:38 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:38 AM

adrian requested review of this revision.Jan 23 2025, 2:38 AM

Harbormaster completed remote builds in B61899: Diff 149737.Jan 23 2025, 2:38 AM

adrian added a parent revision: D48607: net80211: Implement ieee80211_setup_vht_rates().Jan 23 2025, 2:38 AM

adrian added a child revision: D48609: net80211: add node VHT transmit rate helper functions.

adrian added a reviewer: wireless.Jan 23 2025, 3:04 AM

adrian added a project: wireless.

rebase

Harbormaster completed remote builds in B61959: Diff 149848.Jan 24 2025, 1:51 AM

rebase

Harbormaster completed remote builds in B61986: Diff 149900.Jan 24 2025, 3:31 PM

rebase, address changes

Harbormaster completed remote builds in B62052: Diff 150004.Jan 27 2025, 12:16 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62115: Diff 150150.Jan 30 2025, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62130: Diff 150165.Jan 30 2025, 5:16 AM

I am fine with this either way. If you don't want to change this is accepted too.

sys/net80211/ieee80211_phy.c
680	Surprised you don't use a default here for future-proof-ness.

adrian added inline comments.Feb 16 2025, 10:11 PM

sys/net80211/ieee80211_phy.c
680	I want the compiler to complain, it's an enum, right? :)

bz accepted this revision.Feb 16 2025, 10:15 PM

bz added inline comments.

sys/net80211/ieee80211_phy.c
680	Do you ever expect more supported bw in VHT? Fine by me either way.

This revision is now accepted and ready to land.Feb 16 2025, 10:15 PM

Not for VHT, but who knows what we'll end up doing for EHT/HE, what we want to do for half/quarter rates, etc.

Right now ni_chw is the protocol width in the IE, not specifically whatever the PHY is configured as. All kinds of fun stuff may happen in the future!

Closed by commit rG1568caaf5721: net80211: add valid VHT MCS combinations and helper functions (authored by adrian). · Explain WhyFeb 26 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG1568caaf5721: net80211: add valid VHT MCS combinations and helper functions.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_phy.h

7 lines

ieee80211_phy.c

86 lines

Diff 150165

sys/net80211/ieee80211_phy.h

Loading...

sys/net80211/ieee80211_phy.c

Loading...