Differential D48663

tcp: Add a sysctl to affect listening socket behaviour
ClosedPublic
Actions

Authored by markj on Jan 24 2025, 5:04 PM.

Tags

None

Referenced Files

	F154256601: D48663.id.diff
	Mon, Apr 27, 10:48 AM

	Unknown Object (File)
	Tue, Apr 21, 6:22 PM

	Unknown Object (File)
	Tue, Apr 21, 12:21 AM

	Unknown Object (File)
	Mon, Apr 20, 9:32 PM

	Unknown Object (File)
	Mon, Apr 20, 2:00 PM

	Unknown Object (File)
	Mon, Apr 20, 12:06 PM

	Unknown Object (File)
	Sun, Apr 19, 11:30 AM

	Unknown Object (File)
	Tue, Apr 14, 8:39 AM

View All 69 Files

Subscribers

Details

Reviewers

Group Reviewers

network
transport

Commits

rGaa6163ff658b: tcp: Add a sysctl to modify listening socket FIB inheritance
rG5dc99e9bb985: tcp: Add a sysctl to modify listening socket FIB inheritance

Summary

Introduce the net.inet.tcp.bind_all_fibs tunable, set to 1 by default
for compatibility with current behaviour. When set to 0, all TCP
listening sockets are private to their FIB. Inbound connection requests
will only succeed if a matching inpcb is bound to the same FIB as the
request.

No functional change intended, as the new behaviour is not enabled by
default.

Sponsored by: Klara, Inc.
Sponsored by: Stormshield

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62005
Build 58889: arc lint + arc unit

Event Timeline

markj created this revision.Jan 24 2025, 5:04 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 24 2025, 5:04 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

markj requested review of this revision.Jan 24 2025, 5:04 PM

Harbormaster completed remote builds in B62005: Diff 149925.Jan 24 2025, 5:04 PM

markj added a parent revision: D48662: inpcb: Add FIB-aware inpcb lookup.Jan 24 2025, 5:04 PM

markj added a child revision: D48664: udp: Add a sysctl to control binding.

glebius accepted this revision as: glebius.Jan 24 2025, 5:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2025, 4:28 PM

Closed by commit rG5dc99e9bb985: tcp: Add a sysctl to modify listening socket FIB inheritance (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG5dc99e9bb985: tcp: Add a sysctl to modify listening socket FIB inheritance.

markj added a commit: rGaa6163ff658b: tcp: Add a sysctl to modify listening socket FIB inheritance.Feb 21 2025, 1:57 AM

Herald added a subscriber: ziaee. · View Herald TranscriptFeb 21 2025, 1:57 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

32 lines

sys/

netinet/

8 lines

12 lines

2 lines

Diff 149925

share/man/man4/tcp.4

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/tcp_var.h

Loading...