Differential D48318

LinuxKPI: switch jiffies and timer->expire to unsigned long
ClosedPublic
Actions

Authored by bz on Jan 4 2025, 1:54 PM.

Details

Reviewers

emaste

Group Reviewers

linuxkpi

Commits

rGfd27f86dd71b: LinuxKPI: switch jiffies and timer->expire to unsigned long

Summary

It seems these function in Linux work with unsigned long and not int.
Start simply replacing the int where I came across it while debugging
a wireless driver timer modification. Also sprinkle in some "const".

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Jan 4 2025, 1:54 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJan 4 2025, 1:54 PM

bz requested review of this revision.Jan 4 2025, 1:54 PM

Harbormaster completed remote builds in B61500: Diff 148765.Jan 4 2025, 1:54 PM

sys/compat/linuxkpi/common/include/linux/jiffies.h
72	Linux removed timespec_to_jiffies as of 2019, we can follow suit after checking that there are no users left (also jiffies_to_timespec)

This revision is now accepted and ready to land.Jan 7 2025, 7:33 PM

bz added inline comments.Jan 7 2025, 7:42 PM

sys/compat/linuxkpi/common/include/linux/jiffies.h
72	I see no jiffies_to_timespec I also see no timespec_to_jiffies in drm-kmod 5.4-lts, 5.10-lts, 5.15-lts, and 6.1-lts. I seem another #define in sys/dev/drm2/drm_os_freebsd.h which likely is also unused then and should probably just go as well? I'll put another review up for both and add Phabgroup(x11) to catch the graphics people better.