Differential D46935

pf: move pf_test_rule() out of pf_setup_pdesc()
ClosedPublic
Actions

Authored by kp on Oct 4 2024, 12:44 PM.

Tags

None

Referenced Files

	F168941778: D46935.id144585.diff
	Sun, Aug 30, 9:10 PM

	F168836671: D46935.id.diff
	Sun, Aug 30, 9:27 AM

	Unknown Object (File)
	Tue, Aug 25, 7:56 AM

	Unknown Object (File)
	Tue, Aug 25, 5:02 AM

	Unknown Object (File)
	Fri, Aug 21, 3:34 PM

	Unknown Object (File)
	Thu, Aug 20, 8:58 PM

	Unknown Object (File)
	Thu, Aug 20, 7:21 PM

	Unknown Object (File)
	Wed, Aug 19, 5:10 PM

View All 94 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG05896f1ef8be: pf: move pf_test_rule() out of pf_setup_pdesc()

Summary

Move the call to pf_test_rule() for fragments that have not been
reassembled by normalization from pf_setup_pdesc() to pf_test().
This simplifies the paramter list of pf_setup_pdesc() as it can
concentrate on its job filling the pf_pdesc struct.
ok henning mpf

Obtained from: OpenBSD, bluhm <bluhm@openbsd.org>, fb9fe53b92
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 4 2024, 12:44 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptOct 4 2024, 12:44 PM

kp requested review of this revision.Oct 4 2024, 12:44 PM

Harbormaster completed remote builds in B59748: Diff 144237.Oct 4 2024, 12:44 PM

kp added a parent revision: D46934: pf: deduplicate IPv4 and IPv6 code that handles fragments.Oct 4 2024, 12:44 PM

kp added a child revision: D46936: pf: unify some IPv4/IPv6 code in pf_setup_pdesc().

This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2024, 12:38 PM

Closed by commit rG05896f1ef8be: pf: move pf_test_rule() out of pf_setup_pdesc() (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG05896f1ef8be: pf: move pf_test_rule() out of pf_setup_pdesc().

Revision Contents
Changeset List

Path

Size

sys/

net/

3 lines

netpfil/

pf/

41 lines

pf_syncookies.c

2 lines

Diff 144585

sys/net/pfvar.h

Loading...

sys/netpfil/pf/pf.c

Loading...

sys/netpfil/pf/pf_syncookies.c

Loading...