Differential D46940

pf: remove switch (af) default cases
ClosedPublic
Actions

Authored by kp on Oct 4 2024, 12:45 PM.

Tags

None

Referenced Files

	F167926788: D46940.id144242.diff
	Tue, Aug 25, 11:29 AM

	F167870496: D46940.diff
	Tue, Aug 25, 3:37 AM

	F167862978: D46940.id144591.diff
	Tue, Aug 25, 2:08 AM

	F167819204: D46940.id.diff
	Mon, Aug 24, 6:59 PM

	Unknown Object (File)
	Mon, Aug 24, 11:22 AM

	Unknown Object (File)
	Fri, Aug 21, 4:04 PM

	Unknown Object (File)
	Fri, Aug 21, 2:44 PM

	Unknown Object (File)
	Fri, Aug 21, 12:11 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG08b53c6efcae: pf: remove switch (af) default cases

Summary

pf_setup_pdesc() panics if address family is neither AF_INET nor
AF_INET6. So remove useless af switch defaults here and there.
Always use "switch(af)" instead of "if (af) else" for af dependent
code. Always use AF_ defines instead of PF_ when checking af values.
ok claudio mpf henning

Obtained from: OpenBSD, bluhm <bluhm@openbsd.org>, fb75e2fc14
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59753
Build 56639: arc lint + arc unit

Event Timeline

kp created this revision.Oct 4 2024, 12:45 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptOct 4 2024, 12:45 PM

kp requested review of this revision.Oct 4 2024, 12:45 PM

Harbormaster completed remote builds in B59753: Diff 144242.Oct 4 2024, 12:45 PM

kp added a parent revision: D46939: pf: put kif into struct pf_pdesc.Oct 4 2024, 12:45 PM

kp added a child revision: D46941: pf: move the mbuf into struct pf_pdesc too.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2024, 12:43 PM

Closed by commit rG08b53c6efcae: pf: remove switch (af) default cases (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG08b53c6efcae: pf: remove switch (af) default cases.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

48 lines

8 lines

17 lines

7 lines

Diff 144242

sys/netpfil/pf/pf.c

Loading...

sys/netpfil/pf/pf_norm.c

Loading...

sys/netpfil/pf/pf_osfp.c

Loading...

sys/netpfil/pf/pflow.c

Loading...