Keep syncache flags when updating ECN info
ClosedPublic
Actions

Authored by rscheff on Sep 18 2024, 9:12 AM.

Details

Reviewers

cc
tuexen
rrs
glebius

Group Reviewers

transport

Commits

rG8fee873d78eb: tcp: keep syncache flags when updating ECN info
rG77d7da1dc85a: Revert "mca: Allow for passing ECC error record to memory controller driver"
rG0a05ea1f56e6: tcp: keep syncache flags when updating ECN info

Summary

When processing the ECN flags of an incoming packet,
incorrectly cleared all other syncache flags.

Reported by: tuexen

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 59521
Build 56408: arc lint + arc unit

Event Timeline

rscheff created this revision.Sep 18 2024, 9:12 AM

Herald added a reviewer: transport. · View Herald TranscriptSep 18 2024, 9:12 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Sep 18 2024, 9:12 AM

Harbormaster completed remote builds in B59521: Diff 143422.Sep 18 2024, 9:12 AM

tuexen accepted this revision.Sep 18 2024, 9:13 AM

This revision is now accepted and ready to land.Sep 18 2024, 9:13 AM

Closed by commit rG0a05ea1f56e6: tcp: keep syncache flags when updating ECN info (authored by rscheff). · Explain WhySep 18 2024, 9:49 AM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG0a05ea1f56e6: tcp: keep syncache flags when updating ECN info.

stevek added a commit: rG77d7da1dc85a: Revert "mca: Allow for passing ECC error record to memory controller driver".Sep 18 2024, 2:45 PM

rscheff added a commit: rG8fee873d78eb: tcp: keep syncache flags when updating ECN info.Sep 22 2024, 4:25 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

2 lines

Diff 143422

View Options

sys/netinet/tcp_syncache.c

Keep syncache flags when updating ECN infoClosedPublicActions