Page MenuHomeFreeBSD
Differential D46142

cc: remove non-working sctp support
ClosedPublic
Actions

Authored by tuexen on Jul 25 2024, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 5, 5:51 PM
Unknown Object (File)
Tue, Mar 17, 11:09 AM
Unknown Object (File)
Feb 7 2026, 7:06 PM
Unknown Object (File)
Dec 24 2025, 7:01 PM
Unknown Object (File)
Dec 17 2025, 3:13 PM
Unknown Object (File)
Dec 13 2025, 9:26 PM
Unknown Object (File)
Nov 30 2025, 10:25 PM
Unknown Object (File)
Nov 28 2025, 10:48 PM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
lstewart
peter.lei_ieee.org
rrs
rscheff
cc
Group Reviewers
transport
Commits
rG00d3b74406db: tcp cc: remove non-working sctp support
Summary

As suggested by lstewart, remove the non-working SCTP support in the TCP congestion control modules. SCTP has a similar functionality (although not using kernel loadable modules), on which the TCP stuff even was built on, but the integration was never done.

No functional changes intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Jul 25 2024, 10:52 PM
Herald added a reviewer: transport. · View Herald TranscriptJul 25 2024, 10:52 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Jul 25 2024, 10:52 PM
tuexen updated this revision to Diff 141412.Jul 26 2024, 3:41 AM

As suggested by Peter: rename to pointer to the struct tcpcb from tcp to tp.

cc accepted this revision.Jul 26 2024, 2:31 PM

Looks good to me, after the comment update for struct cc_var.

sys/netinet/cc/cc.h
89–90

This whole comment can be removed now or just can be repeated with the comment from its usage in tcpcb.

struct cc_var t_ccv; /* congestion control specific vars */

This revision is now accepted and ready to land.Jul 26 2024, 2:31 PM
tuexen updated this revision to Diff 141450.Jul 26 2024, 5:08 PM

Address comment from cc.

This revision now requires review to proceed.Jul 26 2024, 5:08 PM
tuexen marked an inline comment as done.Jul 26 2024, 5:08 PM
tuexen added inline comments.
sys/netinet/cc/cc.h
89–90

Comment removed.

peter.lei_ieee.org accepted this revision.Jul 27 2024, 5:07 PM
This revision is now accepted and ready to land.Jul 27 2024, 5:07 PM
tuexen marked an inline comment as done.Jul 28 2024, 8:17 PM
Closed by commit rG00d3b74406db: tcp cc: remove non-working sctp support (authored by tuexen). · Explain WhyJul 28 2024, 8:30 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rG00d3b74406db: tcp cc: remove non-working sctp support.

Revision Contents
Changeset List

PathSize
sys/
netinet/
cc/
11 lines
8 lines
2 lines
2 lines
12 lines
6 lines
18 lines
13 lines
10 lines
2 lines
3 lines
2 lines

Diff 141485

View Options

sys/netinet/cc/cc.h

Loading...
View Options

sys/netinet/cc/cc.c

Loading...
View Options

sys/netinet/cc/cc_cdg.c

Loading...
View Options

sys/netinet/cc/cc_chd.c

Loading...
View Options

sys/netinet/cc/cc_cubic.c

Loading...
View Options

sys/netinet/cc/cc_dctcp.c

Loading...
View Options

sys/netinet/cc/cc_htcp.c

Loading...
View Options

sys/netinet/cc/cc_module.h

Loading...
View Options

sys/netinet/cc/cc_newreno.c

Loading...
View Options

sys/netinet/cc/cc_vegas.c

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_usrreq.c

Loading...