Page MenuHomeFreeBSD

Mk/: Possible values for "ssl" are inconsistent
ClosedPublic

Authored by michaelo on Jul 22 2024, 11:26 AM.
Tags
None
Referenced Files
F150814653: D46059.diff
Sat, Apr 4, 5:57 AM
F150811053: D46059.id141218.diff
Sat, Apr 4, 5:21 AM
F150751091: D46059.id141218.diff
Fri, Apr 3, 7:52 PM
F150747309: D46059.id141218.diff
Fri, Apr 3, 7:16 PM
Unknown Object (File)
Wed, Apr 1, 9:18 AM
Unknown Object (File)
Tue, Mar 31, 7:35 AM
Unknown Object (File)
Tue, Mar 31, 12:51 AM
Unknown Object (File)
Wed, Mar 25, 2:09 AM
Subscribers

Details

Summary

PR: 279430
Approved by: jrm (mentor), otis (mentor), brnrd

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58755
Build 55643: arc lint + arc unit

Event Timeline

michaelo created this revision.
This revision is now accepted and ready to land.Jul 23 2024, 10:04 PM

Should add portmgr as a reviewer? There may be a server-side git hook to ensure commits under Mk/ are approved by them.

In D46059#1052323, @jrm wrote:

Should add portmgr as a reviewer? There may be a server-side git hook to ensure commits under Mk/ are approved by them.

Why not, please do.

We probably need a message on each list asking to keep it in sync with the two other.

Anyone else, any objections?

As I said, we need a message at each location saying "update the two other locations", please add it.

Something like this

Mk/Scripts/qa.sh
625–626
Mk/Uses/ssl.mk
11–12
Mk/bsd.default-versions.mk
149
In D46059#1053623, @mat wrote:

Something like this

I see what you are after now, thanks.

This revision now requires review to proceed.Aug 3 2024, 10:27 AM

Issues addressed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 3 2024, 4:01 PM
This revision was automatically updated to reflect the committed changes.