Enable usbhid by default
ClosedPublic
Actions

Authored by emaste on Jun 20 2024, 8:11 AM.

Details

Reviewers

andrew
wulf
bapt
manu

Commits

rG74072e9f16c1: usbhid: Enable by default

Summary

Use usbhid by default and not the old HID stack.
This should be a no functional changes for most users, just the
devices name will change.
If you use fido/u2f keys it's known to not work so you can disable this
by setting hw.usbhid.enable=0 in loader.conf
For users using old touchscreen (like some ELO ones) this avoid using webcamd
as hmt(4) will work fine on them.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58263
Build 55151: arc lint + arc unit

Event Timeline

manu created this revision.Jun 20 2024, 8:11 AM

Herald added a reviewer: andrew. · View Herald TranscriptJun 20 2024, 8:11 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

manu requested review of this revision.Jun 20 2024, 8:11 AM

Harbormaster completed remote builds in B58263: Diff 140024.Jun 20 2024, 8:11 AM

manu added a parent revision: D45658: conf: Add hkbd and hms to GENERIC* kernel configs.Jun 20 2024, 8:11 AM

manu added a reviewer: wulf.Jun 20 2024, 8:11 AM

bapt accepted this revision.Jun 21 2024, 12:14 PM

This revision is now accepted and ready to land.Jun 21 2024, 12:14 PM

LGTM.

But there are still 2 known regressions

Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.
USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

In D45659#1041872, @wulf wrote:

LGTM.

But there are still 2 known regressions

Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.

USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

Thanks, I wasn't aware of those two issues, I'll have a look at those in the next few (working) days. For now I'll hold on on commiting this.

imp added inline comments.Jun 21 2024, 8:29 PM

sys/amd64/conf/GENERIC
328	Why not add hkbd, rather than change ukbd to hkbd?

In D45659#1041872, @wulf wrote:

I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

I forgot about link: https://github.com/wulf7/moused

wulf added inline comments.Jun 21 2024, 9:05 PM

sys/amd64/conf/GENERIC
328	Why not add hkbd, rather than change ukbd to hkbd? That makes sense. To not burn bridges for binary images for some time.

manu added inline comments.Jun 22 2024, 2:25 PM

sys/amd64/conf/GENERIC
328	I'll try to boot this kernel with the sysctl to 0 to check if ukbd still works correctly (it should), if that's the case yes that's probably better, at least at the beginning.

imp added inline comments.Jun 22 2024, 3:06 PM

sys/amd64/conf/GENERIC
328	It's the usual conservative approach. This will also let people file bug reports more easily.

manu updated this revision to Diff 140159.Jun 24 2024, 4:59 AM

manu edited the summary of this revision. (Show Details)

This revision now requires review to proceed.Jun 24 2024, 4:59 AM

manu edited the summary of this revision. (Show Details)Jun 24 2024, 7:12 AM

lwhsu added a subscriber: lwhsu.May 13 2025, 4:12 AM

emaste added inline comments.May 13 2025, 4:47 PM

sys/dev/usb/input/usbhid.c

from SYSCTL(9)

/*
 * Example of a variable integer value.  Notice that the control
 * flags are CTLFLAG_RW, the variable pointer is set, and the
 * value is 0.
 */
static int      doingcache = 1;         /* 1 => enable the cache */
SYSCTL_INT(_debug, OID_AUTO, vfscache, CTLFLAG_RW, &doingcache, 0,
    "Enable name cache");

Default text in share/man/man4/usbhid.4 needs to be updated too

This revision now requires changes to proceed.May 20 2025, 3:25 PM

emaste commandeered this revision.May 20 2025, 6:11 PM

emaste edited reviewers, added: manu; removed: emaste.

This revision now requires review to proceed.May 20 2025, 6:11 PM

Change default in man page

Herald added a subscriber: ziaee. · View Herald TranscriptMay 20 2025, 6:11 PM

There are some regressions still (e.g. fido/u2f as noted). This change will need relnotes, an updating entry, and a heads-up mail.

IMO we can go forward and commit this change before code slush..
FIDO/U2F driver is under review. And moused is in a good enough shape to be widely tested. Both of them are minor changes and i think can be committed after August 8.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2025, 6:32 PM

Closed by commit rG74072e9f16c1: usbhid: Enable by default (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG74072e9f16c1: usbhid: Enable by default.