sbin/ifconfig/af_nd6.c
65–66
75–76	you could move the `#ifdef` to just make these two conditional now?
168–170	If refactoring I'd drop this pseduo-bit-15 hack here and just add a `if (isdefif) printf("...")` assuming `isdefif` is in fact boolean and there isn't some magic here

gordon marked 2 inline comments as done.Jun 3 2024, 3:02 PM

gordon added inline comments.

sbin/ifconfig/af_nd6.c
168–170	I don't think I'm going to try to change the logic here. At least not with this change.

Address comments from emaste.

Harbormaster completed remote builds in B58015: Diff 139353.Jun 3 2024, 3:05 PM

emaste accepted this revision.Jun 3 2024, 3:16 PM

This revision is now accepted and ready to land.Jun 3 2024, 3:16 PM

Move print_bits to ifconfig.c and make available to other src files.
Migrate from printb to print_bits for locally defined bit fields.

This revision now requires review to proceed.Jun 3 2024, 3:18 PM

Harbormaster completed remote builds in B58016: Diff 139354.Jun 3 2024, 3:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2024, 3:52 PM

Closed by commit rGc3e9423743d9: Move print_bits to ifconfig.c and make available to other src files. (authored by gordon). · Explain Why

This revision was automatically updated to reflect the committed changes.

gordon added a commit: rGc3e9423743d9: Move print_bits to ifconfig.c and make available to other src files..

gordon added a commit: rGa68e4f7a0652: Migrate from printb to print_bits for locally defined bit fields..

Will it be feasible to officially MFC this to stable/14? Old code prevents MFC of the upcoming " Implement IPV6 RFC 7217", currently in review D49681.

I am referring to this serie of commits:
commit a68e4f7a065218f0bcc5b34ff8d2e73a240b59b2
Author: Gordon Tetlow <gordon@FreeBSD.org>
Date: Fri May 31 13:58:52 2024 -0700

Migrate from printb to print_bits for locally defined bit fields.

Reviewed by:    emaste
Event:          Kitchener-Waterloo Hackathon 202406
Differential Revision:  https://reviews.freebsd.org/D45441

commit c3e9423743d91ae5b5865602a905900a1855055e
Author: Gordon Tetlow <gordon@FreeBSD.org>
Date: Fri May 31 13:48:10 2024 -0400

Move print_bits to ifconfig.c and make available to other src files.

Reviewed by:    emaste
Event:          Kitchener-Waterloo Hackathon 202406
Differential Revision:  https://reviews.freebsd.org/D45441

The first one is problematic, but probably both have to be MFCed together.

Please ignore. It should be possible to cherry-pick D49681 after it lands without MFC of the above.