Differential D45040

Allow rfork(2) in capsicum(4) capability mode
ClosedPublic
Actions

Authored by trasz on May 1 2024, 10:37 AM.

Tags

None

Referenced Files

	F151869457: D45040.id.diff
	Sat, Apr 11, 5:53 AM

	F151761262: D45040.id137938.diff
	Fri, Apr 10, 12:04 PM

	Unknown Object (File)
	Wed, Apr 8, 8:38 PM

	Unknown Object (File)
	Wed, Apr 8, 7:41 AM

	Unknown Object (File)
	Tue, Apr 7, 5:30 AM

	Unknown Object (File)
	Tue, Apr 7, 4:02 AM

	Unknown Object (File)
	Mon, Apr 6, 2:59 PM

	Unknown Object (File)
	Sat, Apr 4, 8:11 AM

Subscribers

Details

Reviewers

brooks
rwatson

Commits

rG44fb543ac92b: capsicum: allow rfork(2) in capability mode
rG6b7e4254a29e: capsicum: allow rfork(2) in capability mode

Summary

We already allow fork(2), there is no reason not to.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.May 1 2024, 10:37 AM

Herald added a reviewer: brooks. · View Herald TranscriptMay 1 2024, 10:37 AM

Herald added subscribers: olce, imp. · View Herald Transcript

trasz requested review of this revision.May 1 2024, 10:37 AM

Harbormaster completed remote builds in B57492: Diff 137938.May 1 2024, 10:37 AM

If we allow rfork we should presumably allow vfork too. Have you asked @rwatson or @jonathan why they weren't allowed in the first place?

There's a separate review for vfork (https://reviews.freebsd.org/D39829). And yeah, I've pasted Robert the link to this one here :)

brooks accepted this revision.May 2 2024, 6:11 PM

This revision is now accepted and ready to land.May 2 2024, 6:11 PM

rwatson accepted this revision.May 21 2024, 1:01 PM

Closed by commit rG6b7e4254a29e: capsicum: allow rfork(2) in capability mode (authored by trasz, committed by oshogbo). · Explain WhyMay 21 2024, 8:04 PM

This revision was automatically updated to reflect the committed changes.

oshogbo added a commit: rG6b7e4254a29e: capsicum: allow rfork(2) in capability mode.

oshogbo added a commit: rG44fb543ac92b: capsicum: allow rfork(2) in capability mode.May 27 2024, 11:31 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

syscalls.master

2 lines

Diff 138861

sys/kern/syscalls.master

Loading...