Page MenuHomeFreeBSD
Differential D45040

Allow rfork(2) in capsicum(4) capability mode
ClosedPublic
Actions

Authored by trasz on May 1 2024, 10:37 AM.
Tags
None
Referenced Files
F172548061: D45040.diff
Sat, Sep 19, 4:38 AM
Unknown Object (File)
Wed, Sep 2, 7:11 PM
Unknown Object (File)
Wed, Sep 2, 5:47 PM
Unknown Object (File)
Wed, Sep 2, 10:28 AM
Unknown Object (File)
Tue, Sep 1, 5:12 PM
Unknown Object (File)
Aug 17 2026, 2:23 AM
Unknown Object (File)
Aug 12 2026, 12:09 AM
Unknown Object (File)
Aug 11 2026, 5:14 PM
View All Files
Subscribers
imp
jonathan
olce
rwatson

Details

Reviewers
brooks
rwatson
Commits
rG44fb543ac92b: capsicum: allow rfork(2) in capability mode
rG6b7e4254a29e: capsicum: allow rfork(2) in capability mode
Summary

We already allow fork(2), there is no reason not to.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57492
Build 54380: arc lint + arc unit

Event Timeline

trasz created this revision.May 1 2024, 10:37 AM
Herald added a reviewer: brooks. · View Herald TranscriptMay 1 2024, 10:37 AM
Herald added subscribers: olce, imp. · View Herald Transcript
trasz requested review of this revision.May 1 2024, 10:37 AM
Harbormaster completed remote builds in B57492: Diff 137938.May 1 2024, 10:37 AM
brooks added subscribers: rwatson, jonathan.May 1 2024, 4:51 PM

If we allow rfork we should presumably allow vfork too. Have you asked @rwatson or @jonathan why they weren't allowed in the first place?

trasz added a comment.May 1 2024, 10:36 PM

There's a separate review for vfork (https://reviews.freebsd.org/D39829). And yeah, I've pasted Robert the link to this one here :)

brooks accepted this revision.May 2 2024, 6:11 PM
This revision is now accepted and ready to land.May 2 2024, 6:11 PM
rwatson accepted this revision.May 21 2024, 1:01 PM
Closed by commit rG6b7e4254a29e: capsicum: allow rfork(2) in capability mode (authored by trasz, committed by oshogbo). · Explain WhyMay 21 2024, 8:04 PM
This revision was automatically updated to reflect the committed changes.
oshogbo added a commit: rG6b7e4254a29e: capsicum: allow rfork(2) in capability mode.
oshogbo added a commit: rG44fb543ac92b: capsicum: allow rfork(2) in capability mode.May 27 2024, 11:31 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 137938

View Options

sys/kern/syscalls.master

Loading...