Page MenuHomeFreeBSD
Differential D44619

tcp: address warning
ClosedPublic
Actions

Authored by tuexen on Apr 3 2024, 8:16 PM.
Tags
None
Referenced Files
F150336532: D44619.diff
Tue, Mar 31, 7:39 AM
F150316890: D44619.diff
Tue, Mar 31, 3:31 AM
Unknown Object (File)
Sun, Mar 15, 4:13 PM
Unknown Object (File)
Wed, Mar 11, 7:32 PM
Unknown Object (File)
Mon, Mar 9, 6:50 AM
Unknown Object (File)
Jan 27 2026, 12:12 PM
Unknown Object (File)
Dec 24 2025, 9:56 PM
Unknown Object (File)
Dec 24 2025, 12:33 PM
View All 94 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
rrs
rscheff
lstewart
glebius
Group Reviewers
transport
Commits
rGf3e2beb306c6: tcp: address a warning
rG6b454da6bbaa: tcp: address a warning
Summary

t_state is an unsigned variable, so no need for testing that it is non-negative.

Reported by: Coverity Scan
CID: 1390885

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Apr 3 2024, 8:16 PM
Herald added a reviewer: transport. · View Herald TranscriptApr 3 2024, 8:16 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Apr 3 2024, 8:16 PM
glebius accepted this revision.Apr 3 2024, 8:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2024, 10:19 PM
Closed by commit rG6b454da6bbaa: tcp: address a warning (authored by tuexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rG6b454da6bbaa: tcp: address a warning.
tuexen added a commit: rGf3e2beb306c6: tcp: address a warning.Apr 17 2024, 1:55 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 136507

View Options

sys/netinet/tcp_subr.c

Loading...