tcp: address warning
ClosedPublic
Actions

Authored by tuexen on Apr 3 2024, 8:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 10, 2:20 PM

	Unknown Object (File)
	Sun, Nov 30, 5:27 PM

	Unknown Object (File)
	Sat, Nov 29, 9:58 PM

	Unknown Object (File)
	Tue, Nov 25, 6:52 AM

	Unknown Object (File)
	Sat, Nov 22, 10:23 PM

	Unknown Object (File)
	Sat, Nov 15, 10:56 AM

	Unknown Object (File)
	Nov 5 2025, 7:42 AM

	Unknown Object (File)
	Nov 5 2025, 7:29 AM

Subscribers

Details

Reviewers

rrs
rscheff
lstewart
glebius

Group Reviewers

transport

Commits

rGf3e2beb306c6: tcp: address a warning
rG6b454da6bbaa: tcp: address a warning

Summary

t_state is an unsigned variable, so no need for testing that it is non-negative.

Reported by: Coverity Scan
CID: 1390885

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Apr 3 2024, 8:16 PM

Herald added a reviewer: transport. · View Herald TranscriptApr 3 2024, 8:16 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Apr 3 2024, 8:16 PM

glebius accepted this revision.Apr 3 2024, 8:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2024, 10:19 PM

Closed by commit rG6b454da6bbaa: tcp: address a warning (authored by tuexen). · Explain Why

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG6b454da6bbaa: tcp: address a warning.

tuexen added a commit: rGf3e2beb306c6: tcp: address a warning.Apr 17 2024, 1:55 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_subr.c

2 lines

Diff 136507

View Options

tcp: address warningClosedPublicActions