ktls: catch invalid parameters earlier
ClosedPublic
Actions

Authored by rscheff on Mar 14 2024, 9:49 PM.

Details

Reviewers

jhb
tuexen
glebius
rrs
cmiller_netapp.com
siderop1_netapp.com

Group Reviewers

NetApp

Commits

rGb5a9299bb8b9: ktls: catch invalid parameters earlier

Summary

Move safety checks forward from ktls_session_create() to
ktls_copyin_tls_enable(). Prevents zero mallocs, and excessively
large kernel mallocs.

Reported-by: syzbot+72022fa9163fa958b66c@syzkaller.appspotmail.com
Sponsored by: NetApp, Inc.
X-NetApp-PR: #79

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56613
Build 53501: arc lint + arc unit

Event Timeline

rscheff created this revision.Mar 14 2024, 9:49 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 14 2024, 9:49 PM

rscheff requested review of this revision.Mar 14 2024, 9:49 PM

Harbormaster completed remote builds in B56613: Diff 135766.Mar 14 2024, 9:49 PM

tuexen accepted this revision.Mar 14 2024, 10:10 PM

This revision is now accepted and ready to land.Mar 14 2024, 10:10 PM

some compiler trickery to the correct struct member size

This revision now requires review to proceed.Mar 14 2024, 10:30 PM

Harbormaster completed remote builds in B56614: Diff 135767.Mar 14 2024, 10:30 PM

tuexen accepted this revision.Mar 14 2024, 10:48 PM

This revision is now accepted and ready to land.Mar 14 2024, 10:48 PM

Closed by commit rGb5a9299bb8b9: ktls: catch invalid parameters earlier (authored by rscheff). · Explain WhyMar 18 2024, 5:09 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rGb5a9299bb8b9: ktls: catch invalid parameters earlier.

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_ktls.c

69 lines

Diff 135766

View Options

ktls: catch invalid parameters earlierClosedPublicActions