libgcc_s: only export 128-bit int APIs when available
ClosedPublic
Actions

Authored by brooks on Mar 12 2024, 9:11 PM.

Details

Reviewers

emaste
dim
jrtc27
jhb

Commits

rG3f82d8345b17: libgcc_s: only export 128-bit int APIs when available

Summary

These interfaces are only compiled when the platform supports 128-bit
ints. Use a CRT_HAS_128BIT guard similar to the one used in the
compiler_rt sources.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56558
Build 53446: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 12 2024, 9:11 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 12 2024, 9:11 PM

brooks requested review of this revision.Mar 12 2024, 9:11 PM

brooks added a parent revision: D44322: libgcc_s: only export 128-bit long double when available.

Harbormaster completed remote builds in B56558: Diff 135664.Mar 12 2024, 9:11 PM

brooks added a child revision: D44324: libgcc_s: exclude symbols not present on some arches.Mar 12 2024, 9:11 PM

Hm, are these files automagically pulled through a preprocessor? I wasn't aware of that... but yeah, then it is probably a good idea.

This revision is now accepted and ready to land.Mar 12 2024, 9:26 PM

In D44323#1011003, @dim wrote:

Hm, are these files automagically pulled through a preprocessor? I wasn't aware of that... but yeah, then it is probably a good idea.

Somewhat confusingly we have two mechanisms. We have SYMBOL_MAPS where they are preprocessed and then combined with Versions.def to create a version map which a few libraries like libcxxrt use directly. The latter format uses # comments so can't be preprocessed.

Closed by commit rG3f82d8345b17: libgcc_s: only export 128-bit int APIs when available (authored by brooks). · Explain WhyApr 16 2024, 9:15 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG3f82d8345b17: libgcc_s: only export 128-bit int APIs when available.