Restore ${OBJDUMP}
AbandonedPublic
Actions

Authored by brooks on Mar 8 2024, 12:15 AM.

Details

Reviewers

emaste
jrtc27
imp
jhb

Summary

Define an OBJDUMP variable and prefer the cross tools version where
available. Allow XOBJDUMP to override and search for llvm-objdump in
CROSS_BINUTILS_PREFIX to maximize our chances of finding one.

A future commit will use objdump to compare the set of symbols built in
libraries with a reference list.

This reverts commit fd406aa3de47e89456febcaf6cb65d22a6317bc1

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56512
Build 53400: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 8 2024, 12:15 AM

Herald added a subscriber: bdrewery. · View Herald TranscriptMar 8 2024, 12:15 AM

brooks requested review of this revision.Mar 8 2024, 12:15 AM

brooks added a child revision: D44276: cross build: symlink diff and objdump.

Harbormaster completed remote builds in B56512: Diff 135533.Mar 8 2024, 12:15 AM

jhb accepted this revision.Mar 19 2024, 5:00 PM

This revision is now accepted and ready to land.Mar 19 2024, 5:00 PM

A future commit will use objdump to compare the set of symbols built in libraries with a reference list.

No objection, but is there a reason we cannot use nm and/or readelf?

emaste mentioned this in D44276: cross build: symlink diff and objdump.Mar 19 2024, 5:06 PM

In D44275#1013228, @emaste wrote:

A future commit will use objdump to compare the set of symbols built in libraries with a reference list.

No objection, but is there a reason we cannot use nm and/or readelf?

I thought of objdump first. :) After a recent NetBSD post of someone doing something similar with nm I looked at it and nm flags are a portability nightmare (see my follow up email). readelf also has issues (llvm-readelf lacks --use-dynamic), but looking it over I think things might better than using objdump. I'll see about switching to readelf.

I'm going to switch to using readelf