libthr: restore _pthread_cond_timedwait
ClosedPublic
Actions

Authored by brooks on Mar 5 2024, 10:12 PM.

Details

Reviewers

Commits

rG8f86c1082197: libthr: restore _pthread_cond_timedwait

Summary

This was renamed to _thr_cond_timedwait in commit 0ab1bfc7b28f and for
some reason did not get the same weak_reference treatment as other
_pthread_cond symbols.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56510
Build 53398: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 5 2024, 10:12 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 5 2024, 10:12 PM

brooks requested review of this revision.Mar 5 2024, 10:12 PM

Harbormaster completed remote builds in B56467: Diff 135433.Mar 5 2024, 10:12 PM

brooks added a child revision: D44216: Make WITHOUT_UNDEFINED_VERSION the default.Mar 5 2024, 10:12 PM

So why not add the weak alias instead? IMO the change as is makes the omission more severe.

brooks retitled this revision from libthr: stop exporting _pthread_cond_timedwait to libthr: restore _pthread_cond_timedwait.Mar 7 2024, 9:32 PM

Restore weak symbol rather than removing symbol map entry

Harbormaster completed remote builds in B56510: Diff 135531.Mar 7 2024, 9:32 PM

kib accepted this revision.Mar 8 2024, 4:14 AM

This revision is now accepted and ready to land.Mar 8 2024, 4:14 AM

Closed by commit rG8f86c1082197: libthr: restore _pthread_cond_timedwait (authored by brooks). · Explain WhyMar 12 2024, 9:04 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG8f86c1082197: libthr: restore _pthread_cond_timedwait.

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_cond.c

1 line

Diff 135531

View Options

lib/libthr/thread/thr_cond.c

libthr: restore _pthread_cond_timedwaitClosedPublicActions