Page MenuHomeFreeBSD

libthr: restore _pthread_cond_timedwait
ClosedPublic

Authored by brooks on Mar 5 2024, 10:12 PM.
Tags
None
Referenced Files
F86116242: D44244.diff
Sat, Jun 15, 5:13 PM
Unknown Object (File)
Mon, Jun 3, 11:49 AM
Unknown Object (File)
Mon, May 27, 1:52 PM
Unknown Object (File)
Sat, May 25, 3:11 PM
Unknown Object (File)
Sat, May 25, 3:11 PM
Unknown Object (File)
Sat, May 25, 3:11 PM
Unknown Object (File)
Sat, May 25, 5:28 AM
Unknown Object (File)
Thu, May 23, 9:44 PM
Subscribers

Details

Summary

This was renamed to _thr_cond_timedwait in commit 0ab1bfc7b28f and for
some reason did not get the same weak_reference treatment as other
_pthread_cond symbols.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

So why not add the weak alias instead? IMO the change as is makes the omission more severe.

brooks retitled this revision from libthr: stop exporting _pthread_cond_timedwait to libthr: restore _pthread_cond_timedwait.Mar 7 2024, 9:32 PM

Restore weak symbol rather than removing symbol map entry

This revision is now accepted and ready to land.Mar 8 2024, 4:14 AM
This revision was automatically updated to reflect the committed changes.