new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCE
ClosedPublic
Actions

Authored by jhb on Feb 27 2024, 7:47 PM.

Details

Reviewers

imp
andrew
manu

Commits

rGfef01f0498aa: new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCE

Summary

The public bus_adjust_resource() API still accepts both forms, but the
internal kobj method no longer passes the argument. Implementations
which need the type now use rman_get_type() to fetch the value from
the allocated resource.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56301
Build 53189: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 27 2024, 7:47 PM

Herald added a reviewer: andrew. · View Herald TranscriptFeb 27 2024, 7:47 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: olce, jhibbits, emaste. · View Herald Transcript

jhb requested review of this revision.Feb 27 2024, 7:47 PM

Herald added a subscriber: dsl. · View Herald TranscriptFeb 27 2024, 7:47 PM

Harbormaster completed remote builds in B56301: Diff 135117.Feb 27 2024, 7:47 PM

jhb added a parent revision: D44127: pcib: Use rman_get_type in internal functions.Feb 27 2024, 7:47 PM

jhb added a child revision: D44129: new-bus: Remove the 'type' argument from BUS_MAP/UNMAP_RESOURCE.

emaste added inline comments.Feb 27 2024, 7:53 PM

share/man/man9/bus_adjust_resource.9
28	bump on commit, of course

imp accepted this revision.Mar 8 2024, 6:47 PM

This revision is now accepted and ready to land.Mar 8 2024, 6:47 PM

Closed by commit rGfef01f0498aa: new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCE (authored by jhb). · Explain WhyMar 13 2024, 10:14 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGfef01f0498aa: new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCE.

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

bus_adjust_resource.9

13 lines

sys/

arm/

mv/

mv_pci.c

13 lines

arm64/

cavium/

thunder_pcie_pem.c

16 lines

dev/

acpica/

acpi.c

4 lines

acpi_pcib_acpi.c

9 lines

bhnd/

bhndb/

bhndb.c

6 lines

cores/

chipc/

chipc.c

7 lines

dpaa2/

dpaa2_mc.h

2 lines

dpaa2_mc.c

8 lines

fdt/

simplebus.c

14 lines

hyperv/

pcib/

vmbus_pcib.c

6 lines

ofw/

ofw_pcib.c

12 lines

pccbb/

pccbb_pci.c

6 lines

pci/

10 lines

8 lines

10 lines

2 lines

vmd/

vmd.c

10 lines

kern/

bus_if.m

2 lines

subr_bus.c

21 lines

powerpc/

mpc85xx/

lbc.c

16 lines

powermac/

macio.c

15 lines

uninorth.c

15 lines

psim/

iobus.c

15 lines

sys/

bus.h

12 lines

x86/

include/

legacyvar.h

2 lines

pci/

pci_bus.c

6 lines

x86/

mptable_pci.c

7 lines

Diff 135117

View Options

share/man/man9/bus_adjust_resource.9

View Options

sys/arm/mv/mv_pci.c

View Options

sys/arm64/cavium/thunder_pcie_pem.c

View Options

sys/dev/acpica/acpi.c

View Options

sys/dev/acpica/acpi_pcib_acpi.c

View Options

sys/dev/bhnd/bhndb/bhndb.c

View Options

sys/dev/bhnd/cores/chipc/chipc.c

View Options

sys/dev/dpaa2/dpaa2_mc.h

View Options

sys/dev/dpaa2/dpaa2_mc.c

View Options

sys/dev/fdt/simplebus.c

View Options

sys/dev/hyperv/pcib/vmbus_pcib.c

View Options

sys/dev/ofw/ofw_pcib.c

View Options

sys/dev/pccbb/pccbb_pci.c

View Options

sys/dev/pci/pci_host_generic.c

View Options

sys/dev/pci/pci_pci.c

View Options

sys/dev/pci/pci_subr.c

View Options

sys/dev/pci/pcib_private.h

View Options

sys/dev/vmd/vmd.c

View Options

sys/kern/bus_if.m

View Options

sys/kern/subr_bus.c

View Options

sys/powerpc/mpc85xx/lbc.c

View Options

sys/powerpc/powermac/macio.c

View Options

sys/powerpc/powermac/uninorth.c

View Options

sys/powerpc/psim/iobus.c

View Options

sys/sys/bus.h

View Options

sys/x86/include/legacyvar.h

View Options

sys/x86/pci/pci_bus.c

View Options

new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCEClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 135117

share/man/man9/bus_adjust_resource.9

sys/arm/mv/mv_pci.c

sys/arm64/cavium/thunder_pcie_pem.c

sys/dev/acpica/acpi.c

sys/dev/acpica/acpi_pcib_acpi.c

sys/dev/bhnd/bhndb/bhndb.c

sys/dev/bhnd/cores/chipc/chipc.c

sys/dev/dpaa2/dpaa2_mc.h

sys/dev/dpaa2/dpaa2_mc.c

sys/dev/fdt/simplebus.c

sys/dev/hyperv/pcib/vmbus_pcib.c

sys/dev/ofw/ofw_pcib.c

sys/dev/pccbb/pccbb_pci.c

sys/dev/pci/pci_host_generic.c

sys/dev/pci/pci_pci.c

sys/dev/pci/pci_subr.c

sys/dev/pci/pcib_private.h

sys/dev/vmd/vmd.c

sys/kern/bus_if.m

sys/kern/subr_bus.c

sys/powerpc/mpc85xx/lbc.c

sys/powerpc/powermac/macio.c

sys/powerpc/powermac/uninorth.c

sys/powerpc/psim/iobus.c

sys/sys/bus.h

sys/x86/include/legacyvar.h

sys/x86/pci/pci_bus.c

sys/x86/x86/mptable_pci.c

new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCE
ClosedPublic
Actions

Revision Contents
Changeset List