Page MenuHomeFreeBSD
Differential D43904

loader: Only create gfx 4th bindings when gfx is available
ClosedPublic
Actions

Authored by imp on Feb 14 2024, 9:53 PM.
Tags
None
Referenced Files
F150354557: D43904.diff
Tue, Mar 31, 11:45 AM
Unknown Object (File)
Sun, Mar 29, 10:17 PM
Unknown Object (File)
Fri, Mar 27, 12:07 PM
Unknown Object (File)
Sun, Mar 8, 2:41 PM
Unknown Object (File)
Feb 27 2026, 7:53 PM
Unknown Object (File)
Feb 19 2026, 2:08 PM
Unknown Object (File)
Feb 14 2026, 9:52 PM
Unknown Object (File)
Feb 9 2026, 4:09 AM
View All 82 Files
Subscribers
dab
jhb

Details

Reviewers
kevans
tsoome
manu
jhb
Commits
rG254adb825999: loader: Only create gfx 4th bindings when gfx is available
rG9c8bf69a53f6: loader: Only create gfx 4th bindings when gfx is available
Summary

Only create the gfx bindings for 4th when it's comiled into the
kernel. We do this with a linker set that only gets brought in to those
loaders that call gfx_framework_init. This calls gfx_interp_md() will
will drag in gfx_loader.c which will add to the linker set that
registers these bindings.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56022
Build 52911: arc lint + arc unit

Event Timeline

imp created this revision.Feb 14 2024, 9:53 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 14 2024, 9:53 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Feb 14 2024, 9:53 PM
Harbormaster completed remote builds in B56022: Diff 134350.Feb 14 2024, 9:53 PM
imp added a parent revision: D43903: loader: Add prototype for gfx_interp_md.Feb 14 2024, 9:53 PM
imp added a child revision: D43905: loader: Remove gfx_fb_stub.c, it's no longer needed.
jhb accepted this revision.Feb 14 2024, 9:58 PM
jhb added a subscriber: jhb.

s/comile/compile/ in the commit log, and I think you want s/kernel/loader/ in the commit log as well

This revision is now accepted and ready to land.Feb 14 2024, 9:58 PM
imp added a comment.Feb 14 2024, 10:13 PM
In D43904#1001560, @jhb wrote:

s/comile/compile/ in the commit log, and I think you want s/kernel/loader/ in the commit log as well

Updated, thanks!

kevans accepted this revision.Feb 15 2024, 12:40 AM
Closed by commit rG9c8bf69a53f6: loader: Only create gfx 4th bindings when gfx is available (authored by imp). · Explain WhyFeb 16 2024, 4:01 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG9c8bf69a53f6: loader: Only create gfx 4th bindings when gfx is available.
imp added a commit: rG254adb825999: loader: Only create gfx 4th bindings when gfx is available.Apr 16 2024, 8:13 PM

Revision Contents
Changeset List

PathSize
stand/
common/
1 line
ficl/
5 lines
259 lines
188 lines

Diff 134350

View Options

stand/common/gfx_fb.c

Loading...
View Options

stand/ficl/Makefile

Loading...
View Options

stand/ficl/gfx_loader.c

Loading...
View Options

stand/ficl/loader.c

Loading...