Paths

Table of Contentst

Differential D43906

loader: Move to using linker sets to bring in optional bits
ClosedPublic
Actions

Authored by imp on Feb 14 2024, 9:53 PM.

Tags

None

Referenced Files

	F170610035: D43906.diff
	Sat, Sep 5, 3:25 PM

	F170553758: D43906.id134416.diff
	Sat, Sep 5, 9:27 AM

	Unknown Object (File)
	Fri, Sep 4, 5:06 PM

	Unknown Object (File)
	Thu, Sep 3, 5:22 PM

	Unknown Object (File)
	Thu, Sep 3, 2:42 PM

	Unknown Object (File)
	Thu, Sep 3, 1:23 PM

	Unknown Object (File)
	Tue, Sep 1, 9:18 PM

	Unknown Object (File)
	Tue, Sep 1, 7:35 PM

Subscribers

Details

Reviewers

kevans
tsoome
manu
jhb

Commits

rG94e1374b55c7: loader: Move to using linker sets to bring in optional bits
rG0921a771da8a: loader: Move to using linker sets to bring in optional bits

Summary

The graphics stuff is optional. When it is pulled into the system, we
use a linker set to initialize the lua bindings for it now.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Feb 14 2024, 9:53 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 14 2024, 9:53 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Feb 14 2024, 9:53 PM

Harbormaster completed remote builds in B56024: Diff 134352.Feb 14 2024, 9:53 PM

imp added a parent revision: D43905: loader: Remove gfx_fb_stub.c, it's no longer needed.Feb 14 2024, 9:53 PM

imp added a child revision: D43907: loader: Move gfx functions to gfx.lua.8.

jhb accepted this revision.Feb 14 2024, 10:00 PM

jhb added a subscriber: jhb.

jhb added inline comments.

stand/liblua/lutils.h
38
39	Maybe define a `LUA_COMPILE_FOREACH` here as a wrapper around SET_FOREACH so that the `Xficl_compile_set` name is all isolated to here and not also present in interp_lua.c?

This revision is now accepted and ready to land.Feb 14 2024, 10:00 PM

Use LUA_FOREACH_SET

This revision now requires review to proceed.Feb 15 2024, 12:05 AM

Harbormaster completed remote builds in B56030: Diff 134367.Feb 15 2024, 12:05 AM

kevans accepted this revision.Feb 15 2024, 12:41 AM

This revision is now accepted and ready to land.Feb 15 2024, 12:41 AM

Closed by commit rG0921a771da8a: loader: Move to using linker sets to bring in optional bits (authored by imp). · Explain WhyFeb 16 2024, 4:01 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG0921a771da8a: loader: Move to using linker sets to bring in optional bits.

imp added a commit: rG94e1374b55c7: loader: Move to using linker sets to bring in optional bits.Apr 16 2024, 8:13 PM

Revision Contents
Changeset List

Path

Size

stand/

common/

29 lines

liblua/

27 lines

9 lines

Diff 134416

stand/common/interp_lua.c

Loading...

stand/liblua/gfx_utils.c

Loading...

stand/liblua/lutils.h

Loading...