Page MenuHomeFreeBSD
Differential D43860

reboot: Use posix_spawn instead of system
ClosedPublic
Actions

Authored by imp on Feb 13 2024, 4:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 30, 2:52 AM
Unknown Object (File)
Fri, Nov 28, 11:22 PM
Unknown Object (File)
Fri, Nov 21, 8:20 PM
Unknown Object (File)
Wed, Nov 19, 4:39 PM
Unknown Object (File)
Mon, Nov 17, 3:30 PM
Unknown Object (File)
Mon, Nov 10, 10:14 AM
Unknown Object (File)
Mon, Nov 10, 3:23 AM
Unknown Object (File)
Sun, Nov 9, 5:43 PM
View All Files
Subscribers
cy

Details

Reviewers
jrtc27
Commits
rG33a2406eed00: reboot: Use posix_spawn instead of system
Summary

Use posix_spawn to avoid having to allocate memory needed for the system
command line.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 13 2024, 4:50 AM
imp created this revision.
Herald added a subscriber: cy. · View Herald TranscriptFeb 13 2024, 4:50 AM
Harbormaster completed remote builds in B55980: Diff 134238.Feb 13 2024, 4:50 AM
imp added a reviewer: jrtc27.Feb 13 2024, 4:51 AM
jrtc27 added inline comments.Feb 13 2024, 6:55 PM
sbin/reboot/reboot.c
76

Shouldn't there only be one copy?

94–110

Check return value? Especially for EINTR.

104–106

Would seem more natural to flip these two cases?

imp added inline comments.Feb 14 2024, 8:58 PM
sbin/reboot/reboot.c
76

Oh, yes.

94–110

Should we look on EINTR? Or just ignore it?

104–106

sure.

imp updated this revision to Diff 134344.Feb 14 2024, 9:01 PM

Update per reviews

Harbormaster completed remote builds in B56017: Diff 134344.Feb 14 2024, 9:01 PM
imp added a child revision: D43900: loader: Register the gfx stuff separately..Feb 14 2024, 9:55 PM
jrtc27 accepted this revision.Feb 15 2024, 11:17 PM
This revision is now accepted and ready to land.Feb 15 2024, 11:17 PM
Closed by commit rG33a2406eed00: reboot: Use posix_spawn instead of system (authored by imp). · Explain WhyFeb 16 2024, 4:00 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG33a2406eed00: reboot: Use posix_spawn instead of system.

Revision Contents
Changeset List

PathSize
sbin/
reboot/
54 lines

Diff 134408

View Options

sbin/reboot/reboot.c

Loading...