Page MenuHomeFreeBSD

reboot: Use posix_spawn instead of system
ClosedPublic

Authored by imp on Feb 13 2024, 4:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 4:14 AM
Unknown Object (File)
Wed, Nov 27, 7:45 PM
Unknown Object (File)
Oct 30 2024, 2:43 AM
Unknown Object (File)
Oct 21 2024, 4:56 PM
Unknown Object (File)
Oct 21 2024, 4:56 PM
Unknown Object (File)
Oct 19 2024, 1:40 PM
Unknown Object (File)
Oct 19 2024, 1:36 PM
Unknown Object (File)
Oct 19 2024, 1:14 PM
Subscribers

Details

Summary

Use posix_spawn to avoid having to allocate memory needed for the system
command line.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56017
Build 52906: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 13 2024, 4:50 AM
imp created this revision.
sbin/reboot/reboot.c
76

Shouldn't there only be one copy?

94–110

Check return value? Especially for EINTR.

104–106

Would seem more natural to flip these two cases?

sbin/reboot/reboot.c
76

Oh, yes.

94–110

Should we look on EINTR? Or just ignore it?

104–106

sure.

This revision is now accepted and ready to land.Feb 15 2024, 11:17 PM
This revision was automatically updated to reflect the committed changes.