Page MenuHomeFreeBSD
Differential D43855

tcp: partially undo D43792
ClosedPublic
Actions

Authored by rscheff on Feb 12 2024, 8:09 PM.
Tags
None
Referenced Files
F171150181: D43855.diff
Wed, Sep 9, 12:56 AM
Unknown Object (File)
Tue, Sep 8, 6:34 AM
Unknown Object (File)
Sun, Sep 6, 8:34 AM
Unknown Object (File)
Sun, Sep 6, 3:29 AM
Unknown Object (File)
Fri, Sep 4, 2:58 AM
Unknown Object (File)
Thu, Sep 3, 2:37 AM
Unknown Object (File)
Wed, Sep 2, 2:35 PM
Unknown Object (File)
Wed, Sep 2, 1:40 PM
View All Files
Subscribers
• grahamperrin
imp
melifaro

Details

Reviewers
tuexen
rrs
glebius
cc
cy
Group Reviewers
transport
Commits
rG57e27ff07aff: tcp: partially undo D43792
Summary

At the destruction of the tcpcb, no timers are supposed to
be running. However, it turns out that stopping them in the
close() / shutdown() call does not have the desired effect
under all circumstances.

This partially reverts 62d47d73b7eb to reduce the nuisance
caused.

Reported-by: syzbot+9a9aa434a14a2b35c3ba@syzkaller.appspotmail.com
Reported-by: syzbot+e82856782410e895bae7@syzkaller.appspotmail.com
PR: 277009

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55971
Build 52860: arc lint + arc unit

Event Timeline

rscheff created this revision.Feb 12 2024, 8:09 PM
Herald added a reviewer: transport. · View Herald TranscriptFeb 12 2024, 8:09 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Feb 12 2024, 8:09 PM
Harbormaster completed remote builds in B55971: Diff 134224.Feb 12 2024, 8:10 PM
rscheff mentioned this in D43825: tcp: stop all timers in tcp_usr_detach().Feb 12 2024, 8:16 PM
rscheff edited the summary of this revision. (Show Details)
glebius accepted this revision.Feb 12 2024, 8:33 PM

I'm fine with the change if we all agree it is a temporary measure.

tuexen accepted this revision.Feb 12 2024, 9:36 PM
This revision is now accepted and ready to land.Feb 12 2024, 9:36 PM
Closed by commit rG57e27ff07aff: tcp: partially undo D43792 (authored by rscheff). · Explain WhyFeb 12 2024, 9:41 PM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG57e27ff07aff: tcp: partially undo D43792.
• grahamperrin added a subscriber: • grahamperrin.Feb 15 2024, 11:14 PM
glebius added a reverting change: rGe34ea0196f44: tcp: clear all TCP timers in tcp_timer_stop() when in callout.Mar 18 2024, 8:57 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
3 lines

Diff 134224

View Options

sys/netinet/tcp_subr.c

Loading...