Page MenuHomeFreeBSD
Differential D40687

setclassumask(): Accept 'inherit' as a value
ClosedPublic
Actions

Authored by olce on Jun 21 2023, 12:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 19, 8:35 AM
Unknown Object (File)
Mon, May 18, 9:37 PM
Unknown Object (File)
Mon, May 18, 5:48 PM
Unknown Object (File)
Mon, May 18, 6:14 AM
Unknown Object (File)
Mon, May 18, 12:51 AM
Unknown Object (File)
Thu, May 14, 8:29 PM
Unknown Object (File)
Wed, May 13, 11:38 AM
Unknown Object (File)
Mon, May 11, 11:43 PM
View All Files
Subscribers
andrew_tao173.riddles.org.uk
emaste
imp

Details

Reviewers
yuripv
kevans
mjg
des
kib
emaste
Commits
rG6f6186e19fe5: setclassumask(): Accept 'inherit' as a value
rG16e02df98ad6: setclassumask(): Accept 'inherit' as a value
rGc328e6c6ccaa: setclassumask(): Accept 'inherit' as a value
Summary

'inherit' explicitly indicates that the umask should not be changed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55687
Build 52576: arc lint + arc unit

Event Timeline

olce created this revision.Jun 21 2023, 12:38 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 21 2023, 12:38 PM
olce requested review of this revision.Jun 21 2023, 12:38 PM
Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptJun 21 2023, 12:38 PM
Harbormaster completed remote builds in B52217: Diff 123593.Jun 21 2023, 12:38 PM
olce added a parent revision: D40686: setusercontext(): Set umask in a separate function, setclassumask().Jun 21 2023, 1:31 PM
olce added a child revision: D40688: login.conf(5): Document umask's special value 'inherit'.
olce added reviewers: yuripv, kevans, mjg, des, kib.Jun 22 2023, 1:32 PM
olce updated this revision to Diff 123973.Jun 29 2023, 11:33 AM

Remove ret, directly calling login_getcapenum() in the test

Harbormaster completed remote builds in B52328: Diff 123973.Jun 29 2023, 11:33 AM
emaste mentioned this in D40688: login.conf(5): Document umask's special value 'inherit'.Jan 23 2024, 2:58 PM
emaste accepted this revision.Jan 26 2024, 2:29 PM
emaste added a subscriber: emaste.
emaste added inline comments.
lib/libutil/login_class.c
401

TBH if there are no other users of D40684 I would just inline the logic of login_getcapenum here

This revision is now accepted and ready to land.Jan 26 2024, 2:29 PM
olce updated this revision to Diff 133505.Jan 29 2024, 4:45 PM

Address suggestions (move a comment out of an if).

This revision now requires review to proceed.Jan 29 2024, 4:45 PM
Harbormaster completed remote builds in B55687: Diff 133505.Jan 29 2024, 4:45 PM
emaste accepted this revision.Jan 29 2024, 5:44 PM
This revision is now accepted and ready to land.Jan 29 2024, 5:44 PM
Closed by commit rGc328e6c6ccaa: setclassumask(): Accept 'inherit' as a value (authored by olce). · Explain WhyJan 29 2024, 10:32 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGc328e6c6ccaa: setclassumask(): Accept 'inherit' as a value.
olce added a commit: rG16e02df98ad6: setclassumask(): Accept 'inherit' as a value.Feb 1 2024, 9:26 PM
olce added a commit: rG6f6186e19fe5: setclassumask(): Accept 'inherit' as a value.Feb 1 2024, 9:32 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
13 lines

Diff 133505

View Options

lib/libutil/login_class.c

Loading...