netpfil: Use accessor functions and named constants for all tcphdr flags
ClosedPublic
Actions

Authored by rscheff on Dec 24 2023, 4:57 PM.

Details

Reviewers

tuexen
cc
kbowling
glebius

Group Reviewers

transport

Commits

rGa8b70cf26030: netpfil: Use accessor functions and named constants for all tcphdr flags

Summary

Checked source tree for any reference of the struct tcphdr th_x2 field,
which is part of the 12 possible TCP header flags. Changed the access and
use to these high-order bits using the accessor functions.

This should complete the compatibilty of various aspects with AccECN
(TH_AE), after the internal ipfw "re-checksum required" was moved
to use the TH_RES1 flag.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55101
Build 51990: arc lint + arc unit

Event Timeline

rscheff created this revision.Dec 24 2023, 4:57 PM

Herald added subscribers: glebius, ehem_freebsd_m5p.com, melifaro and 4 others. · View Herald TranscriptDec 24 2023, 4:57 PM

rscheff requested review of this revision.Dec 24 2023, 4:57 PM

Harbormaster completed remote builds in B55101: Diff 131797.Dec 24 2023, 4:57 PM

Oh, this causes big header pollution! Is it possible to precede this revision with moving of tcp_get_flags()/tcp_set_flags() into tcp.h? Look, this functions work with the protocol header, they are not related to in kernel implementation of TCP. They really belong to tcp.h.