Page MenuHomeFreeBSD
Differential D43085

tcp: properly unroll sack transmission on tx error with LRD
ClosedPublic
Actions

Authored by rscheff on Dec 18 2023, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 6:34 AM
Unknown Object (File)
Wed, Oct 7, 6:43 AM
Unknown Object (File)
Tue, Sep 29, 6:08 PM
Unknown Object (File)
Tue, Sep 29, 4:03 PM
Unknown Object (File)
Sep 13 2026, 1:45 PM
Unknown Object (File)
Sep 10 2026, 3:22 AM
Unknown Object (File)
Sep 9 2026, 8:52 PM
Unknown Object (File)
Sep 9 2026, 7:39 PM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
cc
tuexen
thj
olivier
rrs
Group Reviewers
transport
Commits
rGac83f3fa44f3: tcp: properly unroll SACK transmission on TX error with LRD
rGe3b9058e5cd0: tcp: properly unroll sack transmission on tx error with LRD
Summary

While going over the code looing at PR275798, I spotted that
with LRD the rewind of the sackhole retransmission pointer
would not necessarily be calculcated correctly. In particular
with LRD, we point to snd_recover when a hole is fully retransmitted.
Need to account for that in case of a local transmission error.

PR: 275798
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54985
Build 51874: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 131519

View Options

sys/netinet/tcp_output.c

Loading...