Page MenuHomeFreeBSD
Differential D42874

tcp: properly initialize LRD while accepting session in syncache
ClosedPublic
Actions

Authored by rscheff on Dec 1 2023, 10:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 12:34 AM
Unknown Object (File)
Fri, Jan 24, 7:29 AM
Unknown Object (File)
Thu, Jan 23, 4:31 PM
Unknown Object (File)
Thu, Jan 23, 6:06 AM
Unknown Object (File)
Thu, Jan 23, 12:00 AM
Unknown Object (File)
Wed, Jan 22, 8:32 PM
Unknown Object (File)
Wed, Jan 22, 12:15 AM
Unknown Object (File)
Tue, Jan 21, 2:43 AM
View All 62 Files
Subscribers
imp
melifaro

Details

Reviewers
zlei
cc
tuexen
rrs
jtl
glebius
thj
Group Reviewers
transport
Commits
rG544bfa7cea3b: tcp: properly initialize LRD while accepting session in syncache
rGf071abd92e72: tcp: properly initialize LRD while accepting session in syncache
Summary

After the recent LRD related changes, I noted that accept()ed
sessions would not honor the per-session TF_LRD flag.

Initialize this not only in tcp_newtcpcb, but also in syncache_socket.

Test Plan

drop a data segment and the retransmission on a SACK session,
verify that another retransmission happens well before the
retransmission timeout.

MFC: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff created this revision.Dec 1 2023, 10:40 PM
Herald added a reviewer: transport. · View Herald TranscriptDec 1 2023, 10:40 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Dec 1 2023, 10:40 PM
Harbormaster completed remote builds in B54743: Diff 130920.Dec 1 2023, 10:40 PM
rscheff added inline comments.Dec 2 2023, 8:19 AM
sys/netinet/tcp_syncache.c
955–956

Alternatively, the TF_LRD flag could be inherited from the listen socket here with (TF_LRD|TF_NOPUSH|TF_NODELAY)

tuexen added inline comments.Dec 2 2023, 10:46 AM
sys/netinet/tcp_syncache.c
955–956

Inheriting is what I would prefer.

rscheff updated this revision to Diff 130939.Dec 2 2023, 11:12 AM
  • inherit LRD setting from listening socket
Harbormaster completed remote builds in B54751: Diff 130939.Dec 2 2023, 11:12 AM
rscheff marked an inline comment as done.Dec 2 2023, 11:12 AM
tuexen accepted this revision.Dec 2 2023, 11:13 AM
This revision is now accepted and ready to land.Dec 2 2023, 11:13 AM
Closed by commit rGf071abd92e72: tcp: properly initialize LRD while accepting session in syncache (authored by rscheff). · Explain WhyDec 2 2023, 11:52 AM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rGf071abd92e72: tcp: properly initialize LRD while accepting session in syncache.
rscheff added a commit: rG544bfa7cea3b: tcp: properly initialize LRD while accepting session in syncache.Dec 16 2023, 10:30 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
3 lines

Diff 130941

View Options

sys/netinet/tcp_syncache.c

Loading...