Page MenuHomeFreeBSD
Differential D41748

init_main: Switch from SLIST to STAILQ, fix order
ClosedPublic
Actions

Authored by cperciva on Sep 5 2023, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 6, 11:03 AM
Unknown Object (File)
Thu, Mar 5, 9:34 PM
Unknown Object (File)
Tue, Mar 3, 5:39 PM
Unknown Object (File)
Tue, Mar 3, 5:47 AM
Unknown Object (File)
Thu, Feb 26, 4:10 PM
Unknown Object (File)
Thu, Feb 26, 7:54 AM
Unknown Object (File)
Sun, Feb 8, 2:27 PM
Unknown Object (File)
Sat, Feb 7, 9:26 PM
View All Files
Subscribers
imp

Details

Reviewers
jhb
gallatin
emaste
Commits
rG3a9ca394c0c9: init_main: Switch from SLIST to STAILQ, fix order
rG144db6a1c9fe: init_main: Switch from SLIST to STAILQ, fix order
rG71679cf468ba: init_main: Switch from SLIST to STAILQ, fix order
Summary

Constructing an SLIST of SYSINITs by inserting them one by one at the
head of the list resulted in them being sorted in anti-stable order:
When two SYSINITs tied for (subsystem, order), they were executed in
the reverse order to the order in which they appeared in the linker
set.

Fixes: 9a7add6d01f3 "init_main: Switch from sysinit array to SLIST"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53453
Build 50344: arc lint + arc unit

Event Timeline

cperciva created this revision.Sep 5 2023, 11:48 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 5 2023, 11:48 PM
cperciva requested review of this revision.Sep 5 2023, 11:48 PM
cperciva added a child revision: D41749: Record completed SYSINITs.
Harbormaster completed remote builds in B53453: Diff 126921.Sep 5 2023, 11:48 PM
gallatin accepted this revision.Sep 6 2023, 4:46 AM

Thank you; this fixes the weird performance problem that we've yet to fully root cause.

This revision is now accepted and ready to land.Sep 6 2023, 4:46 AM
jhb accepted this revision.Sep 6 2023, 3:09 PM
cperciva mentioned this in D41744: Fix order of SYSINITs.Sep 6 2023, 6:24 PM
emaste accepted this revision.Sep 6 2023, 6:26 PM
Closed by commit rG71679cf468ba: init_main: Switch from SLIST to STAILQ, fix order (authored by cperciva). · Explain WhySep 6 2023, 6:37 PM
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rG71679cf468ba: init_main: Switch from SLIST to STAILQ, fix order.
cperciva added a commit: rG144db6a1c9fe: init_main: Switch from SLIST to STAILQ, fix order.Sep 13 2023, 3:48 PM
cperciva added a commit: rG3a9ca394c0c9: init_main: Switch from SLIST to STAILQ, fix order.Sep 13 2023, 8:04 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
22 lines
sys/
2 lines

Diff 126921

View Options

sys/kern/init_main.c

Loading...
View Options

sys/sys/kernel.h

Loading...