Page MenuHomeFreeBSD

init_main: Switch from SLIST to STAILQ, fix order
ClosedPublic

Authored by cperciva on Sep 5 2023, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 7:53 AM
Unknown Object (File)
Mon, Oct 13, 7:53 AM
Unknown Object (File)
Sun, Oct 12, 7:37 PM
Unknown Object (File)
Sun, Oct 12, 7:37 PM
Unknown Object (File)
Sun, Oct 12, 7:37 PM
Unknown Object (File)
Sun, Oct 12, 8:05 AM
Unknown Object (File)
Fri, Oct 10, 5:23 AM
Unknown Object (File)
Fri, Sep 26, 12:38 PM
Subscribers

Details

Summary

Constructing an SLIST of SYSINITs by inserting them one by one at the
head of the list resulted in them being sorted in anti-stable order:
When two SYSINITs tied for (subsystem, order), they were executed in
the reverse order to the order in which they appeared in the linker
set.

Fixes: 9a7add6d01f3 "init_main: Switch from sysinit array to SLIST"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thank you; this fixes the weird performance problem that we've yet to fully root cause.

This revision is now accepted and ready to land.Sep 6 2023, 4:46 AM