Page MenuHomeFreeBSD
Differential D41367

syslogd: Style fixes
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:31 PM.
Tags
None
Referenced Files
F154026357: D41367.diff
Sat, Apr 25, 1:50 PM
Unknown Object (File)
Sat, Apr 25, 10:21 AM
Unknown Object (File)
Wed, Apr 22, 1:35 PM
Unknown Object (File)
Wed, Apr 22, 8:00 AM
Unknown Object (File)
Tue, Apr 21, 8:59 PM
Unknown Object (File)
Tue, Apr 21, 12:34 PM
Unknown Object (File)
Thu, Apr 16, 7:35 PM
Unknown Object (File)
Wed, Apr 15, 6:34 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG929568b9d527: syslogd: Style fixes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jfree created this revision.Aug 8 2023, 3:31 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:31 PM
jfree requested review of this revision.Aug 8 2023, 3:31 PM
jfree added a parent revision: D41366: syslogd: Simplify property filters.
jfree added a child revision: D41368: syslogd: Simplify filed structure.
markj accepted this revision.Aug 9 2023, 7:14 PM
This revision is now accepted and ready to land.Aug 9 2023, 7:14 PM
jfree updated this revision to Diff 125838.Aug 10 2023, 11:10 PM

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:10 PM
markj accepted this revision.Aug 11 2023, 2:50 PM
This revision is now accepted and ready to land.Aug 11 2023, 2:50 PM
emaste accepted this revision.Aug 14 2023, 5:25 PM
emaste added inline comments.
usr.sbin/syslogd/syslogd.c
2355

if this sizeof was done with the rest you could add the space there. (Not sure if it's sizeof() in main or as a result of your sizeof cleanup commit)

jfree added inline comments.Aug 14 2023, 5:41 PM
usr.sbin/syslogd/syslogd.c
2355

if this sizeof was done with the rest you could add the space there. (Not sure if it's sizeof() in main or as a result of your sizeof cleanup commit)

It is sizeof() in main, IIRC. This patch is set before the sizeof() style patch.

Closed by commit rG929568b9d527: syslogd: Style fixes (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:53 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG929568b9d527: syslogd: Style fixes.

Revision Contents
Changeset List

PathSize
usr.sbin/
syslogd/
52 lines

Diff 125838

View Options

usr.sbin/syslogd/syslogd.c

Loading...