Page MenuHomeFreeBSD
Differential D40640

groupmember(): Extract the supplementary group search in a separate function
ClosedPublic
Actions

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
F163995475: D40640.id124436.diff
Mon, Jul 27, 5:29 PM
Unknown Object (File)
Sat, Jul 25, 8:12 PM
Unknown Object (File)
Thu, Jul 23, 6:37 AM
Unknown Object (File)
Tue, Jul 21, 5:58 PM
Unknown Object (File)
Tue, Jul 21, 5:38 PM
Unknown Object (File)
Sun, Jul 19, 10:06 AM
Unknown Object (File)
Sat, Jul 18, 9:17 AM
Unknown Object (File)
Sat, Jul 18, 1:58 AM
View All Files
Subscribers
emaste
imp
mhorne

Details

Reviewers
mjg
kib
dchagin
mhorne
Commits
rGc55330ce4d1a: groupmember(): Extract the supplementary group search in a separate function
rGf373119badd8: groupmember(): Extract the supplementary group search in a separate function
rGf3de805ace48: groupmember(): Extract the supplementary group search in a separate function
rGb725f232f3b0: groupmember(): Extract the supplementary group search in a separate function
Summary

This is in preparation for the introduction of the new realgroupmember()
function, which does the same search into supplementary groups as groupmember().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52175
Build 49066: arc lint + arc unit

Event Timeline

olce created this revision.Jun 20 2023, 1:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 1:45 PM
olce requested review of this revision.Jun 20 2023, 1:45 PM
Harbormaster completed remote builds in B52175: Diff 123506.Jun 20 2023, 1:45 PM
olce added a parent revision: D40639: prison_check(9): Bring up-to-date with hierarchical jails.Jun 20 2023, 2:11 PM
olce added a child revision: D40641: New realgroupmember().
olce added reviewers: mjg, kib, dchagin.Jun 20 2023, 9:03 PM
emaste added a subscriber: emaste.Jun 29 2023, 4:09 PM
mhorne added a subscriber: mhorne.Jul 7 2023, 3:58 PM

The change needs a short description of "why", even just to say that the extracted function will be used in an upcoming change.

Alternatively, if you merged it with D40641, then the why becomes more obvious.

sys/kern/kern_prot.c
1278–1279
olce updated this revision to Diff 124435.Jul 10 2023, 2:27 PM
olce edited the summary of this revision. (Show Details)

Update the commit message.

Harbormaster completed remote builds in B52538: Diff 124435.Jul 10 2023, 2:27 PM
olce updated this revision to Diff 124436.Jul 10 2023, 2:34 PM

Function's parameters style.

Harbormaster completed remote builds in B52539: Diff 124436.Jul 10 2023, 2:34 PM
olce marked an inline comment as done.Jul 10 2023, 2:35 PM
mhorne accepted this revision.Jul 11 2023, 4:49 PM
This revision is now accepted and ready to land.Jul 11 2023, 4:49 PM
Closed by commit rGb725f232f3b0: groupmember(): Extract the supplementary group search in a separate function (authored by olce, committed by mhorne). · Explain WhySep 28 2023, 3:12 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rGb725f232f3b0: groupmember(): Extract the supplementary group search in a separate function.
mhorne added a commit: rGf3de805ace48: groupmember(): Extract the supplementary group search in a separate function.Oct 17 2023, 7:44 PM
mhorne added a commit: rGf373119badd8: groupmember(): Extract the supplementary group search in a separate function.Oct 18 2023, 6:04 PM
olce added a commit: rGc55330ce4d1a: groupmember(): Extract the supplementary group search in a separate function.Dec 21 2023, 1:46 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
52 lines

Diff 123506

View Options

sys/kern/kern_prot.c

Loading...