Page MenuHomeFreeBSD
Differential D40346

setlogincontext(): Comply to style(9)
ClosedPublic
Actions

Authored by olce on May 31 2023, 2:34 PM.
Tags
None
Referenced Files
F84142736: D40346.id123005.diff
Sun, May 19, 11:15 PM
Unknown Object (File)
Sun, May 19, 4:27 PM
Unknown Object (File)
Sun, May 19, 4:27 PM
Unknown Object (File)
Sun, May 19, 4:27 PM
Unknown Object (File)
Sun, May 19, 3:56 PM
Unknown Object (File)
Thu, May 16, 12:00 AM
Unknown Object (File)
Thu, May 16, 12:00 AM
Unknown Object (File)
Fri, May 3, 1:08 AM
View All 38 Files
Subscribers
andrew_tao173.riddles.org.uk
dchagin
imp

Details

Reviewers
kib
mjg
yuripv
kevans
des
emaste
Commits
rG83ac32d9a0f8: setlogincontext(): Comply to style(9)
rG6843f1c2ef08: setlogincontext(): Comply to style(9)
rG771d5c93ab5a: setlogincontext(): Comply to style(9)
Summary

Remove indentation by inverting the big 'if (lc)' and using 'return'.
Use explicit binary operators to produce booleans.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52083
Build 48974: arc lint + arc unit

Event Timeline

olce created this revision.May 31 2023, 2:34 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 31 2023, 2:34 PM
olce requested review of this revision.May 31 2023, 2:34 PM
Harbormaster completed remote builds in B51798: Diff 122653.May 31 2023, 2:34 PM
olce added a parent revision: D40344: setusercontext(): umask: Set it only once (in the common case).May 31 2023, 2:37 PM
olce edited parent revisions, added: D40345: login.conf(5): umask has no default value; removed: D40344: setusercontext(): umask: Set it only once (in the common case).May 31 2023, 3:15 PM
olce added a child revision: D40347: login.conf(5): Default values: Rename column, elaborate on absence of such.
olce added reviewers: kib, mjg, yuripv, kevans, des.Jun 6 2023, 8:03 AM
Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptJun 6 2023, 8:03 AM
olce updated this revision to Diff 123005.Jun 9 2023, 2:38 PM

Update the diff following update of D40344. Same final result.

Harbormaster completed remote builds in B51979: Diff 123005.Jun 9 2023, 2:38 PM
dchagin added a subscriber: dchagin.Jun 15 2023, 12:27 PM
dchagin added inline comments.
lib/libutil/login_class.c
393–394

if ((flags & LOGIN_SETUMASK) != 0) {

and below

olce updated this revision to Diff 123280.Jun 15 2023, 2:03 PM
olce retitled this revision from setlogincontext(): Re-format to comply to style(9) to setlogincontext(): Comply to style(9).
olce edited the summary of this revision. (Show Details)

Explicit booleans in tests.

Harbormaster completed remote builds in B52083: Diff 123280.Jun 15 2023, 2:03 PM
olce marked an inline comment as done.Jun 15 2023, 2:03 PM
olce added inline comments.
lib/libutil/login_class.c
393–394

And above as well. Thanks.

olce marked an inline comment as done.Jun 15 2023, 2:49 PM
kib added inline comments.Jun 18 2023, 5:48 AM
lib/libutil/login_class.c
409

There should be a blank line between locals block and first statement.

422

Same

olce removed a parent revision: D40345: login.conf(5): umask has no default value.Jun 21 2023, 1:37 PM
olce added a parent revision: D40688: login.conf(5): Document umask's special value 'inherit'.
olce updated this revision to Diff 123597.Jun 21 2023, 1:39 PM

Refresh

Harbormaster completed remote builds in B52220: Diff 123597.Jun 21 2023, 1:39 PM
olce marked 2 inline comments as done.Jun 21 2023, 1:41 PM
emaste accepted this revision.Jan 26 2024, 2:31 PM
This revision is now accepted and ready to land.Jan 26 2024, 2:31 PM
Closed by commit rG771d5c93ab5a: setlogincontext(): Comply to style(9) (authored by olce). · Explain WhyJan 29 2024, 10:32 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG771d5c93ab5a: setlogincontext(): Comply to style(9).
olce added a commit: rG6843f1c2ef08: setlogincontext(): Comply to style(9).Feb 1 2024, 9:26 PM
olce added a commit: rG83ac32d9a0f8: setlogincontext(): Comply to style(9).Feb 1 2024, 9:32 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
79 lines

Diff 123280

View Options

lib/libutil/login_class.c

Loading...