LinuxKPI: implement timer_{delete,shutdown}_sync()
ClosedPublic
Actions

Authored by bz on May 16 2023, 9:11 PM.

Details

Reviewers

Group Reviewers

Commits

rG0dd2a3b488f0: LinuxKPI: implement timer_{delete,shutdown}_sync()
rG2e07e885d659: LinuxKPI: implement timer_{delete,shutdown}_sync()

Summary

Implement timer_{delete,shutdown}_sync(), which do not seem to require
anything additional to the already existing del_timer_sync().

Sponsored by: The FreeBSD Foundation
MFC after: 10 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51971
Build 48862: arc lint + arc unit

Event Timeline

bz created this revision.May 16 2023, 9:11 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMay 16 2023, 9:11 PM

bz requested review of this revision.May 16 2023, 9:11 PM

Harbormaster completed remote builds in B51516: Diff 122016.May 16 2023, 9:11 PM

ping6?

Why not just call del_timer_sync() instead of copying the code?

Rather than duplicating code, call what's there already as suggested by @hselasky.

Harbormaster completed remote builds in B51971: Diff 122984.Jun 8 2023, 6:20 PM

Looks good!

This revision is now accepted and ready to land.Jun 9 2023, 12:48 PM

Closed by commit rG2e07e885d659: LinuxKPI: implement timer_{delete,shutdown}_sync() (authored by bz). · Explain WhyJun 9 2023, 10:27 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG2e07e885d659: LinuxKPI: implement timer_{delete,shutdown}_sync().

bz added a commit: rG0dd2a3b488f0: LinuxKPI: implement timer_{delete,shutdown}_sync().Jun 26 2023, 12:10 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

timer.h

2 lines

src/

linux_compat.c

14 lines

Diff 122984

View Options

sys/compat/linuxkpi/common/include/linux/timer.h