netlink: dump interface capabilities with other interface data
ClosedPublic
Actions

Authored by melifaro on May 30 2023, 10:47 AM.

Details

Reviewers

kib

Group Reviewers

network

Commits

rGc344eff91070: netlink: dump interface capabilities with other interface data.

Summary

This change exports interface capabilities using the standard Netlink attribute type, bitset, and switches ifconfig(8) to use it when displaying interface data.

Bitset comes in two representations. The first one is "compact", where the bits are exported via two arrays - "mask" listing the "valid" bits and "values, providing the values for those bits. The second one is more verbose, listing each bit as a separate item, with its name, id and value. The latter option is handy when submitting update requests.

The support for setting capabilities will be added in the upcoming diffs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51771
Build 48662: arc lint + arc unit

Event Timeline

melifaro created this revision.May 30 2023, 10:47 AM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptMay 30 2023, 10:47 AM

melifaro requested review of this revision.May 30 2023, 10:47 AM

Harbormaster completed remote builds in B51771: Diff 122603.May 30 2023, 10:47 AM

melifaro retitled this revision from netlink: add support for getting ifcaps to netlink: dump interface capabilities with other interface data.May 30 2023, 10:58 AM

melifaro edited the summary of this revision. (Show Details)

melifaro added reviewers: network, kib.

afedorov added a subscriber: afedorov.May 30 2023, 9:07 PM

kib added inline comments.Jun 2 2023, 11:52 AM

sys/net/if.h
297	At very least, can you add something along IFCAP_BIT() and make IFCAP_XXX expressed as IFCAP_BIT(IFCAP_B_XXX) and IFCAP2_BIT() as needed?
385	Why do we need this array embedded into each compilation unit including if.h?