Page MenuHomeFreeBSD
Differential D40182

ifconfig: switch IPv4/IPv6 address manipulations to Netlink
ClosedPublic
Actions

Authored by melifaro on May 20 2023, 11:53 AM.
Tags
None
Referenced Files
F171476902: D40182.id122214.diff
Fri, Sep 11, 8:26 AM
Unknown Object (File)
Thu, Sep 10, 12:10 PM
Unknown Object (File)
Sun, Sep 6, 12:03 AM
Unknown Object (File)
Sat, Sep 5, 11:16 AM
Unknown Object (File)
Fri, Sep 4, 7:04 PM
Unknown Object (File)
Thu, Sep 3, 11:22 PM
Unknown Object (File)
Thu, Sep 3, 9:20 AM
Unknown Object (File)
Wed, Sep 2, 2:10 PM
View All Files
Subscribers
imp
otis

Details

Reviewers
None
Group Reviewers
network
Commits
rG4bf44dd73bc0: ifconfig: switch IPv4/IPv6 address manipulations to Netlink.
rG54418f79fd29: ifconfig: switch IPv4/IPv6 address manipulations to Netlink

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro created this revision.May 20 2023, 11:53 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 20 2023, 11:53 AM
melifaro requested review of this revision.May 20 2023, 11:53 AM
Harbormaster completed remote builds in B51577: Diff 122162.May 20 2023, 11:53 AM
melifaro added a parent revision: D40180: ifconfig: simplify ifconfig() by factoring out ifa add/del logic.May 20 2023, 11:54 AM
melifaro added a reviewer: network.
This revision was not accepted when it landed; it landed in state Needs Review.May 22 2023, 1:47 PM
Closed by commit rG54418f79fd29: ifconfig: switch IPv4/IPv6 address manipulations to Netlink (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG54418f79fd29: ifconfig: switch IPv4/IPv6 address manipulations to Netlink.
melifaro added a reverting change: rG26056fa8d348: Revert "ifconfig: switch IPv4/IPv6 address manipulations to Netlink".May 22 2023, 3:19 PM
melifaro added a commit: rG4bf44dd73bc0: ifconfig: switch IPv4/IPv6 address manipulations to Netlink..May 25 2023, 12:22 PM
otis added a subscriber: otis.May 25 2023, 1:45 PM

After this change:

root@b14:~ # ifconfig
vtnet0: flags=1008843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,LOWER_UP> metric 0 mtu 1500
        options=80028<VLAN_MTU,JUMBO_MTU,LINKSTATE>
        ether 58:9c:fc:05:ea:e7
        inet 100.64.0.14 netmask 0xffffff00 broadcast 100.64.0.255
...
root@b14:~ # ifconfig vtnet0 inet 100.64.0.15/24 alias
root@b14:~ # ifconfig
vtnet0: flags=1008843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,LOWER_UP> metric 0 mtu 1500
        options=80028<VLAN_MTU,JUMBO_MTU,LINKSTATE>
        ether 58:9c:fc:05:ea:e7
        inet 100.64.0.14 netmask 0xffffff00 broadcast 100.64.0.255
        inet 100.64.0.15 netmask 0xffffff00 broadcast 100.64.0.255
...
root@b14:~ # ifconfig vtnet0 inet 100.64.0.15 -alias
...

The session stalled. Login via serial console showed:

root@b14:~ # ifconfig
vtnet0: flags=1008843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,LOWER_UP> metric 0 mtu 1500
        options=80028<VLAN_MTU,JUMBO_MTU,LINKSTATE>
        ether 58:9c:fc:05:ea:e7
        inet 100.64.0.15 netmask 0xffffff00 broadcast 100.64.0.255

wrong IP address has been removed.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
184 lines
152 lines
3 lines
22 lines
102 lines
46 lines

Diff 122214

View Options

sbin/ifconfig/af_inet.c

Loading...
View Options

sbin/ifconfig/af_inet6.c

Loading...
View Options

sbin/ifconfig/af_link.c

Loading...
View Options

sbin/ifconfig/ifconfig.h

Loading...
View Options

sbin/ifconfig/ifconfig.c

Loading...
View Options

sbin/ifconfig/ifconfig_netlink.c

Loading...