Paths

Table of Contentst

Differential D40180

ifconfig: simplify ifconfig() by factoring out ifa add/del logic
ClosedPublic
Actions

Authored by melifaro on Sat, May 20, 11:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 28, 2:34 PM

	Unknown Object (File)
	Thu, May 25, 7:14 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG63ad5ce7335b: ifconfig: simplify ifconfig() by factoring out ifa add/del logic

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Sat, May 20, 11:23 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, May 20, 11:23 AM

melifaro requested review of this revision.Sat, May 20, 11:23 AM

Harbormaster completed remote builds in B51576: Diff 122160.Sat, May 20, 11:23 AM

melifaro added a parent revision: D40179: ifconfig: split argument parsing.Sat, May 20, 11:24 AM

melifaro edited the summary of this revision. (Show Details)

melifaro added reviewers: network, kp.

melifaro added a child revision: D40182: ifconfig: switch IPv4/IPv6 address manipulations to Netlink.Sat, May 20, 11:54 AM

kp accepted this revision as: kp.Sat, May 20, 3:39 PM

kp added inline comments.

sbin/ifconfig/ifconfig.c
977	Not blocking here, but we really need to reduce the number of global variables in ifconfig.
983	I think style(9) still requires that declaration to be at the top of a block.

This revision is now accepted and ready to land.Sat, May 20, 3:39 PM

melifaro marked an inline comment as done.Sun, May 21, 9:42 AM

melifaro added inline comments.

sbin/ifconfig/ifconfig.c
977	I agree - that's why I started their merge under `args`. This diff has a specific scope of simplifying ifconfig() function and it doesn't change anything w.r.t the global variable handling.

Closed by commit rG63ad5ce7335b: ifconfig: simplify ifconfig() by factoring out ifa add/del logic (authored by melifaro). · Explain WhySun, May 21, 9:43 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG63ad5ce7335b: ifconfig: simplify ifconfig() by factoring out ifa add/del logic.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

83 lines

Diff 122181

sbin/ifconfig/ifconfig.c

Loading...