Page MenuHomeFreeBSD

ifconfig: simplify ifconfig() by factoring out ifa add/del logic
ClosedPublic

Authored by melifaro on Sat, May 20, 11:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 28, 2:34 PM
Unknown Object (File)
Thu, May 25, 7:14 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp added inline comments.
sbin/ifconfig/ifconfig.c
977

Not blocking here, but we really need to reduce the number of global variables in ifconfig.

983

I think style(9) still requires that declaration to be at the top of a block.

This revision is now accepted and ready to land.Sat, May 20, 3:39 PM
melifaro added inline comments.
sbin/ifconfig/ifconfig.c
977

I agree - that's why I started their merge under args. This diff has a specific scope of simplifying ifconfig() function and it doesn't change anything w.r.t the global variable handling.