Page MenuHomeFreeBSD

ifconfig: simplify ifconfig() by factoring out ifa add/del logic
ClosedPublic

Authored by melifaro on May 20 2023, 11:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 9:19 PM
Unknown Object (File)
Thu, Mar 7, 12:04 PM
Unknown Object (File)
Thu, Mar 7, 11:46 AM
Unknown Object (File)
Thu, Mar 7, 8:50 AM
Unknown Object (File)
Thu, Mar 7, 6:34 AM
Unknown Object (File)
Feb 12 2024, 1:56 PM
Unknown Object (File)
Feb 12 2024, 1:56 PM
Unknown Object (File)
Feb 12 2024, 1:56 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp added inline comments.
sbin/ifconfig/ifconfig.c
977

Not blocking here, but we really need to reduce the number of global variables in ifconfig.

983

I think style(9) still requires that declaration to be at the top of a block.

This revision is now accepted and ready to land.May 20 2023, 3:39 PM
melifaro added inline comments.
sbin/ifconfig/ifconfig.c
977

I agree - that's why I started their merge under args. This diff has a specific scope of simplifying ifconfig() function and it doesn't change anything w.r.t the global variable handling.